bjodah / mdiosvcor

Molecular Dynamics Ion Solvation Correction terms
BSD 2-Clause "Simplified" License
0 stars 0 forks source link

sympy outreach? #1

Open Krastanov opened 12 years ago

Krastanov commented 12 years ago

This is not an official inquiry from the sympy team, however I am one of the people that work on sympy and I suppose that the rest of the team will show similar sentiments:

We would definitely be interested in feedback and feature requests. Also if you have some website or blog on the project it may be interesting to add it to the planet.sympy feed aggregator. I am sorry if it is inappropriate to post this on the issue tracker. Would you be interested to contact us with comments on the mailing list (sympy@googlegroups.com)?

I see that you are using some rarely used functionality in sympy (the autowrap stuff)...

bjodah commented 12 years ago

@Krastanov no worries about posting in issues - any means of getting in touch are good ones. I would definitely be interested in participating and contributing to sympy - it is a great project which makes my life easier. I just joined sympy on groups.google.com - I'll gladly try to patch this myself.

Regarding the autowrap functionality - it is great! I modified it a bit to enable it to store compiled binary for future use (the generation of source code and compilation is non-negligible in my case). If I want to propose to extend autowrap to support this behavior - what is the best way?

Make a post on the email list to see if it would be appreciated, then implement in my own fork and then make a pull request here on github?

Sorry for all the questions but these are my first baby steps in open source development.

Krastanov commented 12 years ago

Yes, what you described is how it usually happens (sometimes even without the preceding email notice)

You can just make a pull request with the changes (forking sympy on github, making the changes to a branch in your fork and just pushing the pull request button). The first time you will be bombarded with comments about adding tests, following documentation style and so on, but do not worry about these.

If you wish you can contact the community on the mailing list, just to be sure that there is nobody working on the same thing at the same time.

By the way @smichr has reacted very quickly and it seems that there is already a fix for your issue.