search

bkaradzic / GENie

GENie - Project generator tool
Other
905 stars 168 forks source link

xcode iOS WindowedApp project has invalid product type #393

Open attilaz opened 5 years ago

attilaz commented 5 years ago

For example https://github.com/bkaradzic/bgfx generated 'examples' project has a product type: 'com.apple.product-type.tool' which is unavailable for iOS (and tvOS ) projects.

It seems it is because this commit: https://github.com/bkaradzic/GENie/commit/d1a1025600264c7267aa5cf81a6a9f48c03ac3fc

SkipBundling should be used only when platform is 'macosx'.

bkaradzic commented 5 years ago

cc @Dentoid

KageKirin commented 5 years ago

I had the same issue (with generated Xcode10 projects). My current workaround is to just patch the generated files with sed: sed -i "" -e "s/com.apple.product-type.tool/com.apple.product-type.application/g" .build/projects/xcode10-ios/MyProj.xcodeproj/project.pbxproj

SonnyBonds commented 5 years ago

Sounds like my previous fix/addition needs some extra conditional. I'm veeeery swamped with things and can't look into this for a while, but it's likely fairly easy for anyone to fix. Sorry.

SonnyBonds commented 5 years ago

Late to the party, but was going to come back and fix this. However, I'm not totally sure how to determine there's an ios build going on. ios doesn't seem to be either a valid platform nor an OS?

Also, while it of course would be nice if it'd automatically ignore it, wouldn't just not specifying SkipBundling for ios targets be a valid workaround?

Just trying to understand the problem and possible solution here.