search

bkeepers / dotenv

A Ruby gem to load environment variables from `.env`.
MIT License
6.6k stars 506 forks source link

Use tagged logger already configured on Rails #489

Closed kriansa closed 9 months ago

kriansa commented 9 months ago

Fixes #488

bkeepers commented 9 months ago

Thanks @kriansa, I'll get a release out soon.

brosintoski commented 9 months ago

this change caused: 

.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/semantic_logger-4.15.0/lib/semantic_logger/base.rb:190:in `block in tagged': no block given (yield) (LocalJumpError)
    from /Users/bradleyrosintoski/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/semantic_logger-4.15.0/lib/semantic_logger/semantic_logger.rb:319:in `fast_tag'
    from /Users/bradleyrosintoski/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/semantic_logger-4.15.0/lib/semantic_logger/base.rb:197:in `tagged'
    from /Users/bradleyrosintoski/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/dotenv-3.0.3/lib/dotenv/rails.rb:93:in `block in <class:Rails>'
rondales commented 7 months ago

Fixes #488

  • fix: call tagged from an existing tagged logger
  • fix: correctly uninitialize logger between runs