bkochuna / ners570f24-SpMV

3 stars 0 forks source link

Add construction/destruction tests for the DEN matrix class #7

Open KyleVaughn opened 2 weeks ago

KyleVaughn commented 2 weeks ago

Description:

Develop a comprehensive set of unit tests to verify the correct construction and destruction of the DenseMatrix class. These tests will ensure that the DenseMatrix objects are properly initialized, can be copied and moved, and are correctly destroyed, maintaining the integrity of the dense matrix representation in our library.

Tasks:

Definition of done:

kaleisss commented 2 days ago

Very good job overall! You considered a lot of possible cases, such as memory leaks the correct invocation of the destructor. It is very nice that you also test for negative dimensions and very large matrices to improve robustness. However, for very large matrices, you might also want to ensure the tests assess performance and memory usage limits of the system.