Revert "cortexar: Read CPUID when the core is powered" - Githubissues

blackmagic-debug / blackmagic

In application debugger for ARM Cortex microcontrollers.

GNU General Public License v3.0

3.29k stars 774 forks source link

Revert "cortexar: Read CPUID when the core is powered" #1994

Closed marysaka closed 2 weeks ago

marysaka commented 2 weeks ago

Detailed description

This reverts commit 9b68194a8dadeb790c03a181c85a84eecb8e73e7.

As reported on Discord, this seems to cause issues on some boards.

The ARMv7-A spec specify that: "If external debug over powerdown is supported, these registers can be implemented in either or both power domains."

This means that the CPUID handling on ARMv7-A is the opposite of what ARMv8-A requires.

Your checklist for this pull request

[x] I've read the Code of Conduct
[x] I've read the guidelines for contributing to this repository
[x] It builds for hardware native (see Building the firmware)
[x] It builds as BMDA (see Building the BMDA)
[x] I've tested it to the best of my ability
[x] My commit messages provide a useful short description of what the commits do

Closing issues

/cc @dragonmux