search

blade-ui-kit / blade-icons

A package to easily make use of SVG icons in your Laravel Blade views.
https://blade-ui-kit.com/blade-icons
MIT License
2.21k stars 148 forks source link

Improve logic for finding svg content #227

Closed dr5hn closed 8 months ago

dr5hn commented 8 months ago

Issue

Stripping tags sometimes doesn't match the content when doing str_replace. Hence it fails applying defer functionality.

Solution

Introducing a regex extraction fixes the issue.

driesvints commented 8 months ago

Hi there. We'd need a test or two to see what this actually fixes.

dr5hn commented 8 months ago

@driesvints Sure will add some tests.

dr5hn commented 8 months ago

@driesvints I've pushed a tests to this branch, but for some reasons they're not showing up.

https://github.com/dr5hn/blade-icons/commit/780e32fb1f189c4970a2ad1a9cacdcf6f0a7ec7d

driesvints commented 8 months ago

@dr5hn GitHub is having issues: https://www.githubstatus.com