search

blade-ui-kit / blade-icons

A package to easily make use of SVG icons in your Laravel Blade views.
https://blade-ui-kit.com/blade-icons
MIT License
2.21k stars 148 forks source link

Improve logic for finding svg content #228

Closed dr5hn closed 8 months ago

dr5hn commented 8 months ago

Issue

Stripping tags sometimes doesn't match the content when doing str_replace. Hence it fails applying defer functionality.

Solution

Introducing a regex extraction fixes the issue.

driesvints commented 8 months ago

Can you add a much more smaller svg? This is quite too much lines..

dr5hn commented 8 months ago

@driesvints Ok will try to compress it to smaller.

driesvints commented 8 months ago

@dr5hn I see your force push but the SVG contents are still the same. I can't merge this in as is sorry. Can you please re-send the PR with a much smaller SVG? Thanks