search

blade-ui-kit / blade-icons

A package to easily make use of SVG icons in your Laravel Blade views.
https://blade-ui-kit.com/blade-icons
MIT License
2.21k stars 148 forks source link

Remove labelled-by attribute from SVG when title attribute is passed #249

Closed aarishgilani closed 3 months ago

aarishgilani commented 3 months ago

@driesvints I discussed this with my team this morning and it looks like the easy solution would be to remove aria-labelledby attribute from SVG's.

This follows the 5th pattern in Deque best practices, which has similar support to pattern 8, which we were using earlier.

So, this:

<x-icon-solid.camera title="camera" />

will result in this:

<svg class="svg-inline--fa fa-arrow-right" role="img" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 448 512">

<title>camera</title>

<path fill="currentColor" d="M438.6 278.6c12.5-12.5 12.5-32.8 0-45.3l-160-160c-12.5-12.5-32.8-12.5-45.3 0s-12.5 32.8 0 45.3L338.8 224 32 224c-17.7 0-32 14.3-32 32s14.3 32 32 32l306.7 0L233.4 393.4c-12.5 12.5-12.5 32.8 0 45.3s32.8 12.5 45.3 0l160-160z"></path>

</svg>

Let me know what you think!

Aarish

closes #248

driesvints commented 3 months ago

Perfect, thanks!