Open mr-c opened 9 years ago
This will be a five-phase submission:
1) transrate-tools, snap-aligner, ruby-fix-trinity-output, ruby-yell, libcereal-dev, libgff-dev, libspdlog-dev, libjellyfish-2.0-dev, libbwa-dev (update), ruby-facade, ruby-colorize (update from 0.7.3 to 0.7.7), ruby-threach
2) salmon, ruby-pathname2
3) ruby-fixwhich
4) ruby-crb-blast
5) transrate itself
@mr-c this is heroic! And very much appreciated. What can we do to support it?
@Blahah Thanks :-) The licenses need clarifying, see https://github.com/Blahah/transrate/issues/159.
In general it seems that the Ruby community is a fan of the MIT license and not putting this in each file nor having a copyright line. Alas this is rather confusing as multiple versions exist, all with the same name. When documenting the license for Debian I can use the short name 'expat' if it exactly matches that variant; otherwise it creates a delay.
Ideally the program licensecheck
(from the devscripts
package) would give me the correct information when scanning source trees.
(sid)255 mcrusoe@localhost:~/debian/transrate-tools$ licensecheck `git ls-files`
src/bam-read.cpp: *No copyright* UNKNOWN
src/bam-read.h: *No copyright* UNKNOWN
src/pileup.cpp: *No copyright* UNKNOWN
src/pileup.h: *No copyright* UNKNOWN
src/segmenter.cpp: *No copyright* UNKNOWN
src/segmenter.h: *No copyright* UNKNOWN
Can I deal with that by just putting a LICENSE file in the repo (see https://github.com/Blahah/transrate-tools/commit/215f661ac19fe847da62f49f56e6b3599aa81b72)?
For transrate-tools & #159 yes, that is required; thanks!
A copyright line in each file would be nice too.
You're right, I never put the license in every file because I find it aesthetically unpleasant - a distraction from the pure utility of the code. But now that you mention it, I see why it would be useful!
Is there some convention for stating the license/copyright as simply as possible?
:-)
I know of no convention, alas. Some licenses give specific guidance on how to use them in a source file; many do not.
For the MIT family of licenses it appears that the best bet is to include the entire license in the header as it is unversioned and so short. See: https://anonscm.debian.org/cgit/collab-maint/devscripts.git/tree/scripts/licensecheck.pl#n593
(DIB lab had the same issue with the BSD license; I ended up adding the full text of the license to every file during a copyright/license audit brought about because seqan didn't declare all of its constituent copyrights and licenses)
Putting the whole MIT license in seems horrible. Would a two-liner like this suffice?
# Copyright Richard Smith-Unna and Chris Boursnell 2015. This file is MIT licensed.
# Full license at: https://github.com/Blahah/transrate/blob/master/LICENSE
Because honestly I'd rather just waive all rights in a short one-liner than have a big header in every file! I would feel sick every time I saw it!
:-)
This variation allows both the copyright and license to be detected:
mcrusoe@localhost:~$ cat test.py
#!/usr/bin/env python
# Copyright 2015 Richard Smith-Unna and Chris Boursnell.
# This file is MIT licensed.
# Full license at: http://opensource.org/licenses/mit-license.php
import this
mcrusoe@localhost:~$ licensecheck --copyright test.py
test.py: MIT/X11 (BSD like)
[Copyright: 2015 Richard Smith-Unna and Chris Boursnell]
OK, deal ;).
Transrate-tools has been accepted into Debian! https://tracker.debian.org/pkg/transrate-tools
snap-aligner has been accepted: https://tracker.debian.org/pkg/snap-aligner
I've received a series of apologies from a debian-ruby team member apologizing for the delays in reviewing my ruby packages.
I'm preparing the salmon package (0.4.1) and I see that version 0.6 is out. @Blahah, when do you expect transrate to be updated to handle the format changes?
@mr-c we'll push a small patch soon addressing reviewer's comments, after which the next release will support the latest salmon. I guess late feb.
Thanks for all your hard work on this :)
Oh my, 16 dependencies! Alas the biggest delay will be waiting for leaf packages to be accepted so those packages that depend on them can be sent in.
Dependencies that need packaging (default) or updates (as marked):
http://anonscm.debian.org/cgit/debian-med/cereal.git
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=800335https://ftp-master.debian.org/new/cereal_1.1.2-1.htmlhttp://tracker.debian.org/pkg/libcerealdebian/copyright
usr/include/cereal/external/
http://anonscm.debian.org/cgit/debian-med/libgff.git
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=800336https://ftp-master.debian.org/new/libgff_1.0-1.htmlhttps://packages.qa.debian.org/libg/libgff.htmlhttp://anonscm.debian.org/cgit/debian-med/spdlog.git
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=800337https://ftp-master.debian.org/new/spdlog_1.4-1.htmlhttps://tracker.debian.org/pkg/spdloghttp://anonscm.debian.org/cgit/debian-med/jellyfish.git
http://anonscm.debian.org/cgit/debian-med/bwa.git
https://ftp-master.debian.org/new/bwa_0.7.12-5.htmlhttp://bugs.debian.org/cgi-bin/bugreport.cgi?bug=800339http://anonscm.debian.org/cgit/debian-med/salmon.githttps://ftp-master.debian.org/new/salmon_0.4.2+ds1-1.htmlhttps://tracker.debian.org/pkg/salmondoc/build/html/_static/jquery.js
&underscore.js
http://anonscm.debian.org/cgit/debian-med/snap-aligner.git
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=800340https://tracker.debian.org/pkg/snap-alignerhttp://anonscm.debian.org/cgit/debian-med/transrate-tools.git
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=800412https://ftp-master.debian.org/new/transrate-tools_1.0.0-1.htmlhttps://tracker.debian.org/pkg/transrate-toolsRuby packages: https://wiki.debian.org/Teams/Ruby/Packaging
https://anonscm.debian.org/cgit/pkg-ruby-extras/transrate.git https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=800733
https://anonscm.debian.org/cgit/pkg-ruby-extras/ruby-fix-trinity-output.git
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=800489https://tracker.debian.org/pkg/ruby-fix-trinity-outputhttps://anonscm.debian.org/cgit/pkg-ruby-extras/ruby-yell.git
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=800494http://tracker.debian.org/pkg/ruby-yellhttps://anonscm.debian.org/cgit/pkg-ruby-extras/ruby-threach.git
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=800734https://ftp-master.debian.org/new/ruby-threach_0.2.0-1.htmlhttps://tracker.debian.org/pkg/ruby-threachhttps://anonscm.debian.org/cgit/pkg-ruby-extras/ruby-crb-blast.git
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=800737https://ftp-master.debian.org/new/ruby-crb-blast_0.6.4-1.htmlhttps://tracker.debian.org/pkg/ruby-crb-blasthttps://anonscm.debian.org/cgit/pkg-ruby-extras/ruby-pathname2.git
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=800740https://ftp-master.debian.org/new/ruby-pathname2_1.7.4-1.htmlhttp://tracker.debian.org/pkg/ruby-pathname2https://anonscm.debian.org/cgit/pkg-ruby-extras/ruby-fixwhich.git
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=800742https://tracker.debian.org/pkg/ruby-fixwhichhttps://anonscm.debian.org/cgit/pkg-ruby-extras/ruby-facade.git
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=800488https://ftp-master.debian.org/new/ruby-facade_1.0.7-1.htmlhttps://tracker.debian.org/news/718538