search

blakeblackshear / blakeshome-charts

Repo for helm charts
41 stars 52 forks source link

deploy `Chart.appVersion` by default and generate valid `resources` #61

Closed mazay closed 1 month ago

mazay commented 4 months ago

While Chart.appVersion is set to 0.13.1 image.tag was 0.12.0 so effectively the older version is deployed by default.

Having the ability to override the default tag is great but it should be empty by default to simplify chart maintenance and avoid confusion.

Also fixed resources block with gpu.nvidia.enabled and user-defined resources, was failing with:

unmarshal errors:
 line 89: mapping key "limits" already defined at line 87
mazay commented 1 month ago

@billimek can this be merged?

The PR fixes 2 annoying issues, one of them is #60 another one has no issues yet as far as I can tell

billimek commented 1 month ago

Resolved conflict with Chart.yaml: