Removing no-unused-variable for tslint 4.0

blakeembrey / tslint-config-standard

A TSLint config for JavaScript Standard Style

Other

358 stars 43 forks source link

Removing no-unused-variable for tslint 4.0 #12

Closed unional closed 7 years ago

unional commented 7 years ago

https://github.com/palantir/tslint/issues/1481

It is deprecated in favor of: https://github.com/Microsoft/TypeScript/wiki/What%27s-new-in-TypeScript#flag-unused-declarations-with---nounusedparameters-and---nounusedlocals

But don't release until https://github.com/Microsoft/vscode-tslint/issues/123 is fixed.

mdurling commented 7 years ago

The following rules all have been deprecated and must be removed:

no-unused-variable no-duplicate-key no-unreachable

unional commented 7 years ago

Fixed tests

unional commented 7 years ago

vscode-tslint fix is release. Good to go. But seems like tests is not triggered.

Project config issue.

mdurling commented 7 years ago

The tslint-eslint-rules package also needs to be updated and the two additional rules removed. See PR #14

unional commented 7 years ago

Sure. Let's use your PR. Closing this one.

mdurling commented 7 years ago

Travis is failing my CI tests. They pass on my local machine. I had to run npm test:gen to create the .out files. Can you take a look? Am I missing something?

unional commented 7 years ago

Clear your local node_modules and try again. I think the eslint-rules has changed its distribution 👎

unional commented 7 years ago

Oh, nope. It's eslint-rules need to update to 4.0 first. It is doing require('tslint/lib/lint') which does not exists in 4.0.

unional commented 7 years ago

Ref: https://github.com/buzinas/tslint-eslint-rules/issues/137

mdurling commented 7 years ago

I was getting this error locally until I updated tslint-eslint-rules (which I included in my PR) and then it worked.

On Mon, Nov 21, 2016 at 11:50 AM Homa Wong notifications@github.com wrote:

Ref: buzinas/tslint-eslint-rules#137 https://github.com/buzinas/tslint-eslint-rules/issues/137

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/blakeembrey/tslint-config-standard/pull/12#issuecomment-261995834, or mute the thread https://github.com/notifications/unsubscribe-auth/ADR8_WMYPNOulKEuTVvK1T7OvDSV257Uks5rAcvNgaJpZM4K3Xbb .

unional commented 7 years ago

I just tried it and 2.2.1 is not working yet.

mdurling commented 7 years ago

It works on my local machine, but tslint-eslint-rules has its own nested copy of tslint (3.15.1)

unional commented 7 years ago

It does say unmet deps for me and using 4.0.1, thus the error. Which version of npm are you using? I'm using 3.10.3