Fix Go package self-test failure, introduced by a9145135

blampe / goat

Render ASCII art as SVG diagrams

MIT License

668 stars 44 forks source link

Fix Go package self-test failure, introduced by a9145135 #30

Closed dmullis closed 5 months ago

dmullis commented 5 months ago

Was previously failing Go package self-test due to incorrect version spec syntax in a9145135, which had "go-version: '1.20'" in test.yml.

Correct status badge stuck on "Passing", hiding CI failures such as the above, by dropping use of GitHub status badges altogether, for reasons elaborated in README.md.tmpl.

Drop Windows-based test: There is no Windows-specific code in Goat.

Tidy the pre-push workflow for contributors.

dmullis commented 5 months ago

Yes, thanks, I've now accepted the invitation (within the time limit).

I do hope you'll be able to continue to be the primary integrator of PRs. For project stability I'm sure it's best to have a BDFL.

Regarding merging of PRs, I noticed that for-blampe-5.0 was "squash-merged", whereas earlier PRs got a merge-commit. To me, merge-commit or rebase-and-merge seem better, primarily because they preserve regression debugging by means of bisecting the patch series.