bldrs-ai / Share

Share is a web-based BIM & CAD collaboration platform.
http://bldrs.ai
103 stars 30 forks source link

Review Note Placemarks existing code #928

Open OlegMoshkovich opened 7 months ago

OlegMoshkovich commented 7 months ago

Understand existing code related to note anchors.

Previous work is documented in #599

Example of a placemark: https://bldrs.ai/share/v/gh/pablo-mayrgundter/freality/master/bldrs/example.ifc?feature=placemark#m:-59.705,26.985,10.857,-45.29,21.349,-12.451,0 Image

OlegMoshkovich commented 7 months ago

Code diagram https://miro.com/app/board/uXjVPrU-gV8=/

image

Figma sketch for the current implementation of the marks https://www.figma.com/file/3ZH7YVQubpaVPMXOYUuHLv/UX-Flow---100?type=design&node-id=1074-896&mode=design&t=qwNU0LISN0CTnUpu-0

URL format http://localhost:8080/share/v/gh/pablo-mayrgundter/freality/master/bldrs/example.ifc?feature=placemark#m:16.309,-0.716,1.004::i:2089011998

OlegMoshkovich commented 7 months ago
image

In the scene, placemarks are not positioned precisely

OlegMoshkovich commented 7 months ago

ToDo:

OlegMoshkovich commented 6 months ago

Image

Need to reorganize note code to allow common methods to be accessed from anywhere in the app

OlegMoshkovich commented 3 months ago

https://bldrs.ai/share/v/gh/pablo-mayrgundter/freality/master/bldrs/example.ifc?feature=placemark#m:-59.705,26.985,10.857,-45.29,21.349,-12.451,0