Changing one module implementation should not affect the calling module generated code.

[MohamedGhardallou]

Hello

Describe the bug please consider the following 3 modules program:

prog.blc

import module2 "module2"
import module3 "module3"

@[EntryPoint]
activity main()( )
  var k : int32 = 5
  await true
  run module2.do_something()(k)
end

module2.blc

import module3 "module3"

module exposes do_something

activity do_something()(k : int32)
    k = 6 
    await true
end

module3.blc

module exposes waitMsec

const MSEC_PER_SYSTICK: nat32 = 1

activity waitMsec (msec: nat32)
  var i: nat32 = msec / MSEC_PER_SYSTICK
  repeat
      await true
      i = i - 1
  until i == 0 end
end

Expected behaviour if we compile this program. the following files are generated :

• module2.blh
• module2.c
• module2.h
• module3.blh
• module3.c
• module3.h
• prog.c
• prog.h

if we change module2 code to

module2.blc

import module3 "module3"

module exposes do_something

activity do_something()(k : int32)
    k = 6 
    await true
    run module3.waitMsec(1000) // we add this call
end

and we recompile , only these files should be changed :

• module2.blh
• module2.c
• module2.h

but what we see is that prog.c is also changed.

[schorg]

It seems that we should reset the id counter for helper variables on recursive compilation.

[schorg]

Fixed this issue in branch issue3. @MohamedGhardallou: feel free to test it, before I merge it into the main branch.

[MohamedGhardallou]

Hello, Yes, the bug is fixed and the calling module generated code is no longer modified.

However I noticed also when you change one activity implemenation in the same module the calling activity code is also modified

module2.blc

import module3 "module3"

module exposes do_something

activity do_job()(k : int32)
    k = 7 
    run module3.waitMsec(1000)
    await true
end

activity do_something()(k : int32)
    k = 6 
    run do_job()(k)
    await true
end

to

module2.blc

import module3 "module3"

module exposes do_something

activity do_job()(k : int32) // activity modified :  waitMsec has been removed
    k = 7 
    await true
end

activity do_something()(k : int32)
    k = 6 
    run do_job()(k)
    await true
end

[schorg]

I think this change cannot be prevented. Currently the whole file is the compilation unit. If we want to prevent that the compilation of activity do_something changes when we changed do_job, we would need a different naming scheme for auxiliary variables, making them unique for every activity or function. Essentially that would mean, we would make functions and activities independent compilation units. Currently we have the design: 1 file = 1 compilation unit = 1 module (or program) = 1 C-file. I am not sure if more fine-grained compilation units would be an advantage.

[MohamedGhardallou]

Apart from debugging the compiler output , i don't see any real advantage i agree.

[schorg]

Issue solved. Merged into main branch