bleskodev / rubyripper

Fork of the original rubyripper from code.google.com/p/rubyripper + some bugs fixes
125 stars 21 forks source link

main.rb:184:in `add': undefined method `empty?' for 1:Fixnum (NoMethodError) #605

Closed Safari77 closed 7 years ago

Safari77 commented 7 years ago

Hmm, it ripped one track ok and then crashed

/wrk/safari/cvs/rubyripper-fork/lib/rubyripper/codecs/main.rb:184:in `add': undefined method `empty?' for 1:Fixnum (NoMethodError)
    from /wrk/safari/cvs/rubyripper-fork/lib/rubyripper/codecs/main.rb:125:in `block in addTags'
    from /wrk/safari/cvs/rubyripper-fork/lib/rubyripper/codecs/main.rb:117:in `each'
    from /wrk/safari/cvs/rubyripper-fork/lib/rubyripper/codecs/main.rb:117:in `addTags'
    from /wrk/safari/cvs/rubyripper-fork/lib/rubyripper/codecs/main.rb:70:in `block in command'
    from /wrk/safari/cvs/rubyripper-fork/lib/rubyripper/codecs/main.rb:66:in `each'
    from /wrk/safari/cvs/rubyripper-fork/lib/rubyripper/codecs/main.rb:66:in `command'
    from /wrk/safari/cvs/rubyripper-fork/lib/rubyripper/encode.rb:137:in `encodeTrack'
    from /wrk/safari/cvs/rubyripper-fork/lib/rubyripper/encode.rb:81:in `block in startEncoding'
    from /wrk/safari/cvs/rubyripper-fork/lib/rubyripper/encode.rb:79:in `each'
    from /wrk/safari/cvs/rubyripper-fork/lib/rubyripper/encode.rb:79:in `startEncoding'
    from /wrk/safari/cvs/rubyripper-fork/lib/rubyripper/encode.rb:70:in `addTrack'
    from /wrk/safari/cvs/rubyripper-fork/lib/rubyripper/secureRip.rb:99:in `ripTrack'
    from /wrk/safari/cvs/rubyripper-fork/lib/rubyripper/secureRip.rb:74:in `block in ripTracks'
    from /wrk/safari/cvs/rubyripper-fork/lib/rubyripper/secureRip.rb:70:in `each'
    from /wrk/safari/cvs/rubyripper-fork/lib/rubyripper/secureRip.rb:70:in `ripTracks'
    from /wrk/safari/cvs/rubyripper-fork/lib/rubyripper/secureRip.rb:59:in `startTheRip'
    from /wrk/safari/cvs/rubyripper-fork/lib/rubyripper/rubyripper.rb:63:in `startRip'
    from ./rubyripper_gtk2:387:in `block in updateInterfaceAndStartRip'
bleskodev commented 7 years ago

Thanks for reporting. It should be fixed now. Can you confirm? Thanks.

bleskodev commented 7 years ago

Considering the bug fixed. Closing the issue.