search

bleskodev / rubyripper

Fork of the original rubyripper from code.google.com/p/rubyripper + some bugs fixes
125 stars 21 forks source link

unwanted conversion of underlines to spaces in filenames in rubyripper 0.8 #628

Closed grattle closed 3 years ago

grattle commented 3 years ago

Using rubyripper 0.80rc1, current today, in preferences my Base Directory '/big/new_music/rubyrip_rips/' becomes '/big/new music/rubyrip rips/' in the ripped files. Underscores replaced by spaces. No such issue with your previous version 0.7 in its various incarnations.

Other than setting my Base Directory, my CDROM offset, and ripping only to flac, everything has been left at default.

Have I not set something correctly? Or just a programing oops in the new version? Or user error?

bleskodev, thanks for the great job you have done keeping this indispensable program alive.

bleskodev commented 3 years ago

Hi, thanks for your kind words. Yes I see where is the problem. Currently, if you want to keep underscores in your path (and replace the existing spaces!), you need to check the 'Replace spaces with underscores in file names' check box under Codecs tab in the preferences. By default this checkbox is not checked so, surprisingly, the underscores are removed! It seems this is by design, although I don't really know the reason (there are unit tests which confirm this behavior and it seems this behavior was (is?) wanted).

Also, this code hasn't changed recently, so I think the same behavior must be present in 0.7 version.

grattle commented 3 years ago

In hindsight, it may well have been longer since i ripped CD's, like before you kindly took over at v 0.7+. I tend to get flac downloads now, but just bought some new CDs and noticed this issue.

I see the inverse of 'Replace spaces with underscores in file names' is not 'replace underscores with spaces in file names', but 'don't replace spaces with underscores in file names'. With the current option selected, my track filenames are quite ugly.

I think that is logical, but I concede I may be the only one who thinks so.

Really, I don't care that much. My eventual simple solution was to simply use a Base Folder with no underscores in it and leave that potentially misnamed underscore option off. I was just mentioning it as a minor issue that may confuse the odd person.

The important thing is I can't pick the difference between a CD and a flac rip using RubyRipper on AB testing on a very good system. A deep thank you for your efforts.

bleskodev commented 3 years ago

Of course, you are absolutely right. The behavior is not logical, I completely agree. I have no idea why it was coded like this; a bug or a weird feature? I'll try to analyze the consequences of changing the existing behavior to something more conventional.

bleskodev commented 3 years ago

Hi, I have changed the behavior of the option in question; it should now behave as expected (do nothing if not activated). Thanks for reporting this issue!