bleskodev / rubyripper

Fork of the original rubyripper from code.google.com/p/rubyripper + some bugs fixes
125 stars 21 forks source link

Crashed when trying to add replay gain for Opus encodes #631

Closed FoilBlue closed 3 years ago

FoilBlue commented 3 years ago

wavegain dep was missing btw.

$ rrip_gui 
/usr/local/lib/rubyripper/secureRip.rb:335: warning: constant ::Fixnum is deprecated
WARNING: No replaygain available for opus.
#<Thread:0x00007f1afcdc7f80 /usr/local/lib/rubyripper/encode.rb:85 run> terminated with exception (report_on_exception is true):
Traceback (most recent call last):
    2: from /usr/local/lib/rubyripper/encode.rb:86:in `block (2 levels) in startEncoding'
    1: from /usr/local/lib/rubyripper/encode.rb:153:in `encodeTrack'
/usr/local/lib/rubyripper/codecs/main.rb:60:in `replaygainAlbum': undefined method `%' for nil:NilClass (NoMethodError)
Traceback (most recent call last):
    2: from /usr/local/lib/rubyripper/encode.rb:86:in `block (2 levels) in startEncoding'
    1: from /usr/local/lib/rubyripper/encode.rb:153:in `encodeTrack'
/usr/local/lib/rubyripper/codecs/main.rb:60:in `replaygainAlbum': undefined method `%' for nil:NilClass (NoMethodError)
FoilBlue commented 3 years ago

my system: Used drive : HL-DT-ST DVDRAM GSA-4167B DL11 Ubuntu 20.04.2 LTS Gnome 3.36.8 with gnome-shell x11 Rip seamed to complete successfully btw

FoilBlue commented 3 years ago

Oh! Meant to say big THANK YOU!!! :D So happy to be still able to use ruby ripper :D. Fav ripper. Spent ages finding it as a teenager.

bleskodev commented 3 years ago

Hi, first of all, thanks for your kind words! It is really appreciated.

Concerning the problem you have; can you give me just a bit more information? What kind of codec you are trying to use (Opus and some other at the same time or only Opus)? You have activated replaygain for Opus (replaygain for Opus does not exist, but this should issue a warning not cause the crash) or you have activated replaygain for several codecs? You say that wavegain dependency was missing... you were ripping to wave too?

Thanks!

FoilBlue commented 3 years ago

Thank you again :D.

opus and flac. not encoding to wave. Replay gain settings that seam to be applied to everything by the looks of the config screen, The dropdown/checkbox.

I thought maybe rubyripper does not rip to output formats directly and starts with ripped wave files, then applies replay gain -if option enabled-, then transcoded into other formats. Hence i guessed it mattered if wavegain was not installed.

bleskodev commented 3 years ago

OK, I have reproduced your problem. Fix is available if you can get the latest. It would be great if you could confirm the fix. Thanks!

FoilBlue commented 3 years ago

git pulled and installed Rubyripper version 0.8.0rc3

FoilBlue commented 3 years ago

Oh thank you for your efforts!

FoilBlue commented 3 years ago

just did a quick test :). yes it works. Added replygain to the flacs but not the opus encode and didnt crash :). just ripped one track to save time on old already ripped cd.

Thank you again so much! :D

bleskodev commented 3 years ago

Cool!