search

bleskodev / rubyripper

Fork of the original rubyripper from code.google.com/p/rubyripper + some bugs fixes
125 stars 21 forks source link

Support "other" command #637

Closed lilole closed 1 year ago

lilole commented 2 years ago

Hello fellow rubyripper. I like what you have done with updates to the code, and your version is now the one that comes from the user repository for my Arch Linux distro.

However I found that my "Other" preference setting to process the wav files from the rip stopped working. I believe I have fixed it here. At least it works for me now, and I added an rspec to prove the new codec interface.

Note that most of the changed lines here are just removal of dead trailing whitespace. You can set the "hide whitespace" option in the Github diff viewer to reduce the number of lines.

I hope you find this useful. Rubyripper is still the best audio ripper for me.

bleskodev commented 1 year ago

Hey, thanks a lot for your work! I'm sorry for the delay when merging this PR.

lilole commented 1 year ago

Hey, thanks a lot for your work! I'm sorry for the delay when merging this PR.

Cool. No problem at all, I figure you're super busy. Would you like any other rspecs related to this, or more testing?

Honestly I'm not super confident that I understand some of the code paths here, so I'm not very confident that these changes did not break something else.

If you get some bug reports just let me know. I haven't been able to find another ripper tool with GUI that allows a fully customized encoding option like this one, so for me this will continue to be my first choice tool, and I'm willing to help you out with it.

bleskodev commented 1 year ago

If you can think of some more tests (rspec) to add for this feature, it is always a good thing. If not, it is ok. Concerning eventual regressions, we'll monitor if someone notices something and fix as it appears. From what I have seen in your commit, it should be fine. In any case, good job!