blikblum / VirtualTreeView-Lazarus

Virtual Treeview is a treeview control
50 stars 15 forks source link

Updating repo? #5

Open PascalRiekenberg opened 6 years ago

PascalRiekenberg commented 6 years ago

Are you going to update this repo with the changes of Virtual-TreeView/Virtual-TreeView?

Maybe it's a good idea to make Virtual-TreeView/Virtual-TreeView lazarus compatible. They are willing to accept changes. See Issues of Virtual-TreeView/Virtual-TreeView.

blikblum commented 6 years ago

The fpc compiler does not support the syntax used by current Delphi version.

It's possible but it will need to remove some features

PascalRiekenberg commented 6 years ago

Isn't there a common syntax for Delphi and Lazarus? Do you have sample of this Delphi-only syntax?

blikblum commented 6 years ago

The generic methods GetNodeData etc

PascalRiekenberg commented 6 years ago

Don't they work in fpc trunk? If not, they maybe can IFDEFed out for fpc .

blikblum commented 6 years ago

No. Trunk does not work

PascalRiekenberg commented 6 years ago

Okay, I see. You reported it in 2011 already :-(

salvadorbs commented 4 years ago

After two years, any chance to see some updates in this repo? Is it impossible or do you need any help? Thank you very much.

PascalRiekenberg commented 4 years ago

The goal should be to update JAM-Software/Virtual-TreeView to make it work with Lazarus. But i do not have the time to do this. So help is welcome here.

blikblum commented 4 years ago

Unfortunately i know how to do but also do not have time.

TommySlokky commented 4 years ago

Could you at least make a new official patch release containing all the Mac fixes with e.g. column drawing. The problem is Lazarus team is trying to ship their own Lazarus Treeview control, but as far as I know they do not contain any of the Mac paint glitches and column draw fixes.... It is a bit of a mess.... (And yes, they also seem to be ditching compability...)

blikblum commented 4 years ago

@TommySlokky Done

TommySlokky commented 4 years ago

I will comment as testing the new download:

The lcl-extensions need the "cocoa" folder in "include" folder. Otherwise you get a compilation error. I can try email those that have been working.

I believe it correspons to this entry: https://github.com/blikblum/VirtualTreeView-Lazarus/issues/8#issuecomment-415819617

TommySlokky commented 4 years ago

VirtualTrees.pas line 6082 fix if Tree Is TCustomVirtualDrawTree and Assigned(Node) then to if (Tree Is TCustomVirtualDrawTree) and (Assigned(Node)) then otherwise you get error: Operator is not overloaded: Class of TCustomVirtualDraw and Boolean

blikblum commented 4 years ago

VirtualTrees.pas line 6082 fix

What compiler are you using?

Here with fpc 3.2.0 windows 32 bit it compiles fine

TommySlokky commented 4 years ago
blikblum commented 4 years ago

The lcl-extensions need the "cocoa" folder in "include" folder. Otherwise you get a compilation error. I can try email those that have been working.

I updated lclextensions file

blikblum commented 4 years ago

otherwise you get error: Operator is not overloaded: Class of TCustomVirtualDraw and Boolean

This seems to be a bug in fpc trunc. I fixed nonetheless and updated the release

TommySlokky commented 4 years ago

Great!

One problem though while testing the new build... :(

It seems column borders are no longer drawn.

This has worked in an earlier build. (I think I have a copy of that build)

Not sure if related to: https://github.com/blikblum/VirtualTreeView-Lazarus/issues/15

Or maybe emergence of something related to: https://github.com/blikblum/VirtualTreeView-Lazarus/issues/14

Let me know if you need me to test anything?

blikblum commented 4 years ago

What OS?

I can only test on windows or linux

TommySlokky commented 4 years ago

(Mac, Cocoa) will report back when I know more (but if you aready have ideas now for what I can try let me know)

TommySlokky commented 4 years ago

For what it is worth, vtbasic demo also shows without column borders

TommySlokky commented 4 years ago

For now I have posted here https://forum.lazarus.freepascal.org/index.php/topic,32856.msg378680.html#msg378680

And also references in the LCL Mac Cocoa forum, so if anyone else can duplicate the problem as well, maybe they can share some insight.

TommySlokky commented 4 years ago

Created https://github.com/blikblum/VirtualTreeView-Lazarus/issues/20 about the data columns border