Added click fix for firefox and safari

blivesta / rippler

:construction_worker: Effect that spreads like a wave in touch or click.

http://git.blivesta.com/rippler/

346 stars 59 forks source link

Closed nr007 closed 9 years ago

blivesta commented 9 years ago

Thank you for your contribution! worked on safari?

nr007 commented 9 years ago

Thank you for your work ;) Yes. I tested it on Safari, Firefox and IE.

blivesta commented 9 years ago

Nice!. But effect(ripple) does not work on my safari (OSX 8.0.6). 😭 Do you set the url in href?

<a href="https://github.com" class="btn btn-primary rippler rippler-default">
  Rippler link
</a>

nr007 commented 9 years ago

Actually i am using Emberjs (tested on windows - Safari 5.1.7) and not defining href explicitly. But anchor get handled with on click event.

blivesta commented 9 years ago

Ok, This was fixed based on feedback. it work on firefox, safari, IE, chrome. https://github.com/blivesta/rippler/commit/aab78faefac41cdf8115db06dc583e910459fddb Can you able to check the work of rippler? Thanks!

nr007 commented 9 years ago

I found that fix in opened issues. I tried back then and i tried it now again. In Ember it does not work. It makes my view refresh on anchor click.

blivesta commented 9 years ago

Can you provide a example?