search

blmayer / ereandel

A Gemini web browser using shell script
gemini://terminal.pink/
MIT License
56 stars 6 forks source link

make cachehome configurable #12

Closed rnwgnr closed 2 years ago

rnwgnr commented 2 years ago

Hi! Not sure if this is anything you'd consider but here we go: "cachehome" folder is now configurable via astro.conf

My main use case: astro makes heavy use of files (for history and links within pages), which are stored inside [cachehome]/astro/. I want the cachehome to be configurable to move these working files to a memory-backed folder (e.g. via tmpfs).

blmayer commented 2 years ago

Hi guzzisti.

Nice idea, I just want you to adjust some little things before I approve your PR.

By the way, it would be nice if you could take a look at the shellcheck issues:

Notice: ./astro:116:20: note: Double quote to prevent globbing and word splitting. [SC2086]
Warning: ./astro:330:24: warning: Use single quotes, otherwise this expands now rather than when signalled. [SC2064]

I'm not sure if this still happening. Thanks.

rnwgnr commented 2 years ago

I might annoy you with more PRs in the next days. ;)

blmayer commented 2 years ago

That will be great.

blmayer commented 2 years ago

Merged, thanks again.