search

bloc97 / Anime4K

A High-Quality Real Time Upscaler for Anime Video
https://bloc97.github.io/Anime4K/
MIT License
18.51k stars 1.35k forks source link

Fixed Key Bindings bug on MacOS IINA #248

Open reddiedev opened 2 months ago

reddiedev commented 2 months ago

Problem

After following the Instructions for IINA to install Anime4k on IINA, the key binds would not work (no output on OSD or on IINA logs). However, when I was trying it with mpv (and using the same config directory), the commands for Anime4k worked.

Root Cause

Ultimately, I don't think this is due to Anime4k's installation method, but rather due to how IINA registers the key bindings in the active configuration file. I am not sure of any way to fix it from within Anime4k, so I am sharing the fix i found below.

Workaround

I followed the workaround from below and added the guide on how to implement on the install instructions for MacOS/IINA

Please refer to the original IINA issue for context

Tama47 commented 2 months ago

I don't think this is due to Anime4k's installation method, but rather due to how IINA registers the key bindings in the active configuration file.

Correct! I haven't used IINA in a while, but unless something has changed, I remember that mpv key bindings do work with IINA when I originally made the guide.

And thanks for the fix! Would you mind exporting the new config file for IINA and have users download that instead? Just so that it would be easier and more straightforward than to have IINA users manually duplicate and create a new config file themselves.