blockmason / lndr-mobile

LNDR mobile app in React Native
http://lndr.io/
15 stars 10 forks source link

Increased transaction limits based on BCPT stacking and KYC #373

Closed willbach closed 6 years ago

willbach commented 6 years ago
  1. Jira: https://blockmason.atlassian.net/browse/LNDR-20
  2. Problem: The user should have an increased settlement limit of $2,000/week when KYC has been completed and $750/week if they have 25 BCPT staked to their account
  3. Solution: Check if the user has had KYC completed, if so, multiply the settlement limit by 10. If they have 25 BCPT in their Lndr wallet/address, multiply the settlement limit by 3.75 (a user can only have 1 or the other, if they have both it will be 10x settlement limit)
  4. No concerns or tradeoffs
  5. No blockers
canterberry commented 6 years ago

For posterity and easy scannability, showing the math:

:bulb: Let's say, hypothetically, we changed the default limit to $250/week. Should that inherently affect the other limits as well, (i.e: $937.50 w/BCPT, $2,500 w/KYC), or do we want to set these limits independently of one another? If the former, then the current logic of having a multiplier is fine. If the latter, it may be more straight-forward to hard-code those limits instead.

willbach commented 6 years ago

@arutun yes, using a SpinningPicker inside of a Modal improved performance for the country chooser