search

bloomberg / clangmetatool

A framework for reusing code in Clang tools
https://bloomberg.github.io/clangmetatool/
Apache License 2.0
119 stars 25 forks source link

ENG2STAAR-2224: Fix bug in `clangmetatool::SourceUtil::isPartialMacro` #52

Closed envp closed 4 years ago

envp commented 4 years ago

Issue number of the reported bug or feature request: # ENG2STAAR-2224

Describe your changes Replacements created for source ranges overlapping with token pasted __VA_ARGS__ are currently faulty. This is a quick fix which can be used by downstream systems to issue warnings.

Testing performed New test data has been added as the case033-detect-partial-macro-expansion. This includes a test driver for the positve & negative cases and accompanying source files with the syntax under test.

envp commented 4 years ago

cc: @dbeer1 @HaltCatchFire @begroh

envp commented 4 years ago

@dbeer1 Sorry, forgot to delete an unused header.

envp commented 4 years ago

cc: @azeemba @ruoso for merge