bloomberg / memray

Memray is a memory profiler for Python
https://bloomberg.github.io/memray/
Apache License 2.0
13.17k stars 392 forks source link

Allow to create non-minimized javascript files #398

Closed pablogsal closed 1 year ago

pablogsal commented 1 year ago

To make debugging of the generated javascript possible, we need to allow to set minimize: false in the webpack.config.js file. Unfortunately this has some problems:

To help with this, add a new globally available function in the jinja templates that allows us to include files without interpolating them and fix the order-of-definition problems.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.31 :warning:

Comparison is base (c2c8d53) 85.41% compared to head (2c0c57a) 85.11%.

:exclamation: Current head 2c0c57a differs from pull request most recent head af53113. Consider uploading reports for the commit af53113 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #398 +/- ## ========================================== - Coverage 85.41% 85.11% -0.31% ========================================== Files 29 29 Lines 3621 3621 ========================================== - Hits 3093 3082 -11 - Misses 528 539 +11 ``` | Flag | Coverage Δ | | |---|---|---| | cpp | `85.11% <ø> (-0.31%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bloomberg#carryforward-flags-in-the-pull-request-comment) to find out more. [see 2 files with indirect coverage changes](https://app.codecov.io/gh/bloomberg/memray/pull/398/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bloomberg)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.