search

blue-build / modules

BlueBuild standard modules used for building your Atomic Images
Apache License 2.0
26 stars 4 forks source link

fix: Signing module failing copying ublue-os cosign public key #317

Closed gmpinder closed 3 months ago

gmpinder commented 3 months ago

I'm seeing the error cp: cannot stat '/usr/share/ublue-os/cosign.pub': No such file or directory from the signing module. I'm not sure if this is something due to upstream but we should get this fixed

fiftydinar commented 3 months ago

I got this error here: https://github.com/blue-build/modules/pull/315

But it's gone when I reverted to signing module as is now.

However, you have this error without any modifications to signing module?

Yeah, this looks like it could be an upstream Ublue issue.

ublue-os/cosmic images also miss policy.json

So I think it's the issue with ublue-os-signing RPM package (not an Rechunker issue, since it's not used in main images, where issue can still be reproduced)

gmpinder commented 3 months ago

Oh looks like the build errors I'm getting are cause of the change in main. I think I temporarily fixed it with this https://github.com/blue-build/cli/commit/82606cc1440fad61da75b876b4d716e9b6837463. I should release a patch version before we merge the module changes in

xynydev commented 3 months ago

I didn't get this error with the main branch 15 hours ago nor now. Likely an issue with the PR then. Releasing a patch version is a good idea. I'll approve all the /usr/etc/ PRs, so y'all can merge them when ready. Notify me and I'll have the announcement posted everywhere. The next nine hours would be a good timespan for me for this, otherwise this change will get pushed back to next week.

fiftydinar commented 3 months ago

Oh looks like the build errors I'm getting are cause of the change in main. I think I temporarily fixed it with this blue-build/cli@82606cc. I should release a patch version before we merge the module changes in

Ah, makes sense why it works...

Agree on releasing a CLI patch version before merging PRs.

fiftydinar commented 3 months ago

@xynydev I'm ready & available for merging stuff in the similar time window as you.

fiftydinar commented 3 months ago

Fixed in BlueBuild CLI v0.8.12