blue-build / modules

BlueBuild standard modules used for building your Atomic Images
Apache License 2.0
26 stars 4 forks source link

fix(default-flatpaks): Implement limited automatic restart if service failed #356

Open fiftydinar opened 1 month ago

fiftydinar commented 1 month ago

Revert commit: https://github.com/blue-build/modules/pull/355

The issue with the previous setup was that infinite loop restarts could potentially happen (when user has no internet connection or similar), which is a no go (even with the restart limits set).

This is something I encountered for some unrelated systemd service I tested.

Information online about how systemd restart behaves in units is very confusing & conflicting, some say that some options are outdated, some undocumented, some non-working etc.

https://serverfault.com/questions/736624/systemd-service-automatic-restart-after-startlimitinterval

So to avoid potential bad scenario, restart on failure for default-flatpaks services is temporarily disabled.

Let's explore some working fix & work on this.