Open matejzero opened 3 years ago
bluecmd
commented
3 years ago Hello, we should definitely add this!
Could you tell me if you want to monitor only the SVC - i.e. that it proxies all the metrics for the V5000, or it would be in addition?
Do you know if this controller thing exists as a virtual machine? If I could find a trial of it I could try to run it towards my V7000 but otherwise we can probably work with you providing the .jsonnet dumps and reviewing my suggested code.
matejzero
commented
3 years ago I think it should only be an addition as one can attach any block storage to SVC and use it as storage source.
I don't think the SVC is available as a VM, it only comes as an appliance.
V5000/V7000, SVC and Flashsystem provide similar commands with almost identical output. As I wrote in the top ticket, for starters, you could only check what system we are pooling and based on that, use specific command or, in case of SVC, not collect lsenclosurestats, lsdrive or lsenclosurepsu metrics as they don't generate any output on SVC
I'm a bit disapointed that IBM doesn't expose more detailed metrics over API. There is an option to enable collection of statistics (startstat), but the XML is only available over SCP. There are detailed statistics for mdisk, vdisk, node, cache, cluster, FC, iSCSI,... But we have to work with what we have:)
I'll try to generate some JSON tomorrow if you need it. And that for willing to work on this:)
olemyk
commented
2 years ago Hi @bluecmd
Trying to see if get this Exporter to work against. SVC - (8.5 code)
And it from what is can see the, the lsnodecanisterstats have now "0.x" in the field. so im getting this error message:
2022/09/21 19:34:32 Loaded 2 API credentials 2022/09/21 19:34:32 Spectrum Virtualize exporter running, listening on ":9747" 2022/09/21 19:34:35 Error: json: cannot unmarshal number 0.150 into Go struct field nodeStat.stat_current of type int 2022/09/21 19:34:35 Probe of "https://10.33.7.56:7443" failed, took 0.293 seconds
I'm not that familiar with GO, but from what i understand it's the StatCurrent with int that's the issue her? any help is appreciated
type nodeStat struct {
NodeID string `json:"node_id"`
StatName string `json:"stat_name"`
StatCurrent int `json:"stat_current,string"`
}
var st []nodeStat
if err := c.Get("rest/v1/lsnodecanisterstats", "", &st); err != nil {
log.Printf("Error: %v", err)
return false
}
for _, s := range st {
if s.StatName == "compression_cpu_pc" {
mCmpCPU.WithLabelValues(s.NodeID).Set(float64(s.StatCurrent) / 100.0)
} else if s.StatName == "cpu_pc" {
mSysCPU.WithLabelValues(s.NodeID).Set(float64(s.StatCurrent) / 100.0)2022/09/21 19:34:32 Loaded 2 API credentials 2022/09/21 19:34:32 Spectrum Virtualize exporter running, listening on ":9747" 2022/09/21 19:34:35 Error: json: cannot unmarshal number 0.150 into Go struct field nodeStat.stat_current of type int 2022/09/21 19:34:35 Probe of "https://10.33.7.56:7443" failed, took 0.293 seconds
{
"node_id": "1",
"node_name": "SVC02_N1_75ARCC0",
"stat_name": "vdisk_w_io",
"stat_current": "332",
"stat_peak": "567",
"stat_peak_time": "220921152635"
},
{
"node_id": "1",
"node_name": "SVC02_N1_75ARCC0",
"stat_name": "vdisk_w_ms",
"stat_current": "0.193",
"stat_peak": "0.816",
"stat_peak_time": "220921152715"
},
Hey,
we have IBM SVC infront of V5000 and FlashSystems. I check your exporter and it works on V5000, but not on SVC itself, since some commands are different on SVCs.
For example,
lsnodecanisterstatsdoes not exists, but you can uselssystemstatsfor the same output for cluster-wide metrics orlsnodestatsfor per-node output.lssystemstatsdoesn't havenode_idandnode_namerows, butlsnodestatsdoes.Example:
No change needed:
lsmdiskgrplsportfclsportipA few commands don't exists / make sense on SVC:
lsenclosurestats: can't find a replacement and the command errors withCMMVC6051E An unsupported action was selected.lsdrive: most of SVCs don't have local drives, but the command doesn't error out, there just isn`t any responselsenclosurepsu: empty response, didn't find replacement commandOutput of
lssystemcan be used to determine the product type. There is aproduct_namefield:There are some other metrics one could monitor on SVC storage, such as
lsquorumfor alerting when quorum is down as quorum is storage and network based.Not sure how useful it is, but an info metrics could be generated from
lsnodeoutput with labels such asIs this something you would be interesting to implement? Just asking, in case you don't want / have time, I will write my own exporter in Python (I don't know Go, so can't extend your). I'm more than happy to test and provide example REST outputs if needed.