bluekitchen / btstack

Dual-mode Bluetooth stack, with small memory footprint.
http://bluekitchen-gmbh.com
Other
1.74k stars 614 forks source link

HID host optionally disable fetching report descriptor #635

Open Slion opened 1 month ago

Slion commented 1 month ago

Is your feature request related to a problem? Please describe. Especially in the context of multiple HID connections the storage of report descriptors in a single buffer is problematic. Say if you want up to 8 connections you should have like a 4KB buffer with each device having up to a 512KB descriptor. Then your app still need to copy those descriptors anyway as they are moved around the buffer when devices a disconnecting. See: https://github.com/bluekitchen/btstack/issues/633#issuecomment-2414631948 On top of that the app may need to do the exact same SDP query to fetch other attributes anyway. So being able to disable that SDP query would prevent a redundant query, see: #618

Adding documentations to hid_host_init would be great too.

Describe the solution you'd like Do not fetch report descriptor when hid_host_init is passed a NULL pointer and/or a size of zero.

Describe alternatives you've considered None

Possible solution

static void hid_host_handle_start_sdp_client_query(void * context){
    UNUSED(context);
    btstack_linked_list_iterator_t it;    
    btstack_linked_list_iterator_init(&it, &hid_host_connections);

    while (btstack_linked_list_iterator_has_next(&it)){
        hid_host_connection_t * connection = (hid_host_connection_t *)btstack_linked_list_iterator_next(&it);

        switch (connection->state){
            case HID_HOST_W2_SEND_SDP_QUERY:
                connection->state = HID_HOST_W4_SDP_QUERY_RESULT;
                connection->hid_descriptor_status = ERROR_CODE_UNSUPPORTED_FEATURE_OR_PARAMETER_VALUE;
                break;
            default:
                continue;
        }
        /* Don't fetch report descriptor if no storage for it */
        if (hid_host_descriptor_storage_len==0 || hid_host_descriptor_storage=NULL){
            return;
        }
        /* Issue SDP query to fetch report descriptor */
        hid_descriptor_storage_init(connection);
        hid_host_sdp_context_control_cid = connection->hid_cid;
        sdp_client_query_uuid16(&hid_host_handle_sdp_client_query_result, (uint8_t *) connection->remote_addr, BLUETOOTH_SERVICE_CLASS_HUMAN_INTERFACE_DEVICE_SERVICE);
        return;
    }
}