search

bluesky-social / atproto

Social networking technology created by Bluesky
Other
6.17k stars 432 forks source link

OAuth: Enable to configure scope via query parameter for loopback client metadata #2753

Closed sugyan closed 1 month ago

sugyan commented 1 month ago

The draft OAuth Spec says that for localhost clients, the scope "can be configured via query parameter in the client_id URL", and "Default is atproto”, but this was not the case. https://github.com/bluesky-social/atproto-website/blob/bnewbold/spec-oauth/content/specs/auth.md#localhost-client-development So I implemented it to work as per the spec.

matthieusieben commented 1 month ago

Hey ! Thank you for you suggestion. This issue was actually reported to us yesterday and I already started integrating that fix in another branch.

Since both are changes redundant, and because this branch did not account for "multiple allowed" part of the spec, I'll go ahead and close this PR in favor of the other one.

Feel free to comment / open another issue.