Feature request: Light background for code mirror

blueteafrog / logseq-gunmetal-theme

MIT License

19 stars 1 forks source link

Feature request: Light background for code mirror #4

Closed AvijeetPrasad closed 2 years ago

AvijeetPrasad commented 2 years ago

Hi,

I really like your theme and have been using it both in light and dark mode. Thanks a lot for making this wonderful theme :) One issue that would really help me is, if we can have a lighter background for the code mirror as well. In the current version, I feel the code mirror is too dark and looks somewhat cut off from the rest of the page aesthetic. A light blue background (like the one that you use for block embeds) would probably be more desirable.

I am uploading a sample screenshot that illustrates this point. Screenshot 2022-04-21 at 15 12 15

Thanks again!

blueteafrog commented 2 years ago

@AvijeetPrasad Thanks for using the theme and for your feedback. Sure, I'll look into over the weekend!

blueteafrog commented 2 years ago

@AvijeetPrasad I like your suggestions flows better with the light theme. Have a look please give me your opinion before I finalize the update.

AvijeetPrasad commented 2 years ago

Hi! Thanks for the update. The code mirror looks great now :)

I have a couple of related feedback/requests:

In the current version (v 0.1.0), the selected text inside the code mirror wasn't properly highlighted. Maybe you can have a look at that as well.
A minor request: for the code language background color, maybe something more subtle than orange can be used.

Thanks again for this very useful theme :)

blueteafrog commented 2 years ago

Thanks again for the feedback, are you referring to (see screenshots), as far as the code language background change, I'll need some time to look into it. Possibly over the weekend. Screen Shot 2022-04-27 at 3 41 12 PM Screen Shot 2022-04-27 at 3 43 18 PM

AvijeetPrasad commented 2 years ago

Hi, thanks for the updates. Yes, I was referring to the selection highlighting in the code mirror as shown in your screenshots. Earlier, the contrast was a bit less. Now it looks great :)

Thanks for looking into the code language background as well, but I would say that's a minor issue, and it would be already quite helpful if you can push the current updates :) Thanks again!

blueteafrog commented 2 years ago

@AvijeetPrasad should be finalized let me know if you experience any issues with the new update.

AvijeetPrasad commented 2 years ago

Looks great now 😀. Thanks a lot!