bluewave-labs / bluewave-onboarding

https://bluewavelabs.ca
GNU Affero General Public License v3.0
30 stars 24 forks source link

BE: API key & code snippet #332

Open gorkem-bwl opened 4 weeks ago

gorkem-bwl commented 4 weeks ago

That complements #331

image

d02ev commented 2 weeks ago

Hi @erenfn and @gorkem-bwl, I would like to work on this issue. Please assign it to me.

gorkem-bwl commented 2 weeks ago

Assigned to you @d02ev - thanks!

d02ev commented 2 weeks ago

Are there any BE validations for API_KEY and SERVER_URL?

erenfn commented 2 weeks ago

You can skip that for now. Also #340 (its frontend) is now merged

d02ev commented 2 weeks ago

Hi @erenfn, I have some business logic queries:

  1. Is the API_KEY and SERVER_URL saved together in the DB ? or It can be anyone at a time ? That is, should there be a single endpoint for storing both of them ? or one for each ?
  2. For now, I have kept these columns as nullable in the DB. Is this fine ?
erenfn commented 2 weeks ago

1- Single endpoint to store all of them 2-Yes

d02ev commented 2 weeks ago

Please review #345 for this issue.

d02ev commented 1 week ago

Please review #347 which is similar to #345, which I had to close due to some branch rebasing issues.