Closed ajhollid closed 6 days ago
The pull request modifies the isLoading
variable's initial state in the IncidentTable
component, changing it from true
to false
. This change means the component will not show a loading state by default upon rendering. The logic for data fetching remains intact, with the loading state still being set to true
during data retrieval and reset afterward. Other functionalities, including error handling and pagination, are unaffected.
File Path | Change Summary |
---|---|
Client/src/Pages/Incidents/IncidentTable/... | Changed initial state of isLoading from true to false in IncidentTable component. |
Incidents
component to change the parameters passed to the getMonitorsByTeamId
function, which is relevant to the loading behavior of the IncidentTable
component in the main PR.Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
This PR changes the default
loading
state on the incident tage tofalse
. In the case when there are no monitors, the page returns without doing anything to theloading
state, so the page is stuck in loading status.This results in the wrong view presented when no monitors exist.
false
. It should only be set totrue
when a network operation begins.