blw-ofag-ufag / eCH-0265

eCH-0265 -- Agrardaten - Flächen und Kulturen
0 stars 0 forks source link

Link agronomicCropCategory with a botanical species #33

Open AFoletti opened 3 weeks ago

AFoletti commented 3 weeks ago

digiFLUX would like to see an easy way to limit the available choices of botanical species according to the agronomicCropCategory user choice.

Example: The user picks "Winterweizen" as agronomicCropCategory --> the botanical species multiple choice is limited to the species which are allowed for this CropCategory.

Currently, agronomicCropCategory (see https://github.com/blw-ofag-ufag/eCH-0265/blob/4b5d9be03984dcf3ec2024519458119a873086de/src/eCH-0265-1-0.xsd#L427) is an enumeratedType. The link between the CropCategory and the botanical species is done thanks to the botanicalPlantType complex type. See: https://github.com/blw-ofag-ufag/eCH-0265/blob/4b5d9be03984dcf3ec2024519458119a873086de/src/eCH-0265-1-0.xsd#L350C24-L350C42 and https://github.com/blw-ofag-ufag/eCH-0265/blob/4b5d9be03984dcf3ec2024519458119a873086de/src/eCH-0265-1-0.xsd#L395

Since the botanical plants are meant to be taken from the EPPO database, I think we should rework the whole.

Other miscellaneous info:

@hurni your thoughs on that?

hurni commented 3 weeks ago

Mapping botanical species and agronomicCropCategory should be feasible and also helpful for others than digiFLUX. This would have to be an n:n-relation as far as I know.

Example: The user picks "Winterweizen" as agronomicCropCategory --> the botanical species multiple choice is limited to the species which are allowed for this CropCategory.

Should Implementations such as filtering/multiple choice really be done by a the standard or not rather by a specific application? Nonetheless, I think the BLW should provide datasets/lists which contains all the information required.

Additionally we need a mapping of species and varieties.

Currently, agronomicCropCategory (see

https://github.com/blw-ofag-ufag/eCH-0265/blob/4b5d9be03984dcf3ec2024519458119a873086de/src/eCH-0265-1-0.xsd#L427

) is an enumeratedType. The link between the CropCategory and the botanical species is done thanks to the botanicalPlantType complex type. See: https://github.com/blw-ofag-ufag/eCH-0265/blob/4b5d9be03984dcf3ec2024519458119a873086de/src/eCH-0265-1-0.xsd#L350C24-L350C42 and https://github.com/blw-ofag-ufag/eCH-0265/blob/4b5d9be03984dcf3ec2024519458119a873086de/src/eCH-0265-1-0.xsd#L395

Since the botanical plants are meant to be taken from the EPPO database, I think we should rework the whole.

I agree whole-heartedly!

  • botanicalPlantType should simply be a reference to an EPPO code. We should not publish a codelist for that, since the master will be EPPO.

  • agronomicCropCategory should be expanded from a "simple" enumeratedType to a complexType including not only a code and description but also a list of valid EPPO codes. The list of valid EPPO codes for each agronomicCropCategory must be delivered by subject matter experts.

Alternative suggestion: instead of building more complex datasets, we could splint into several lists/datasets. Finding the relevant master and holding the dataowners accountable might prove way simpler.

BLW should provide a dataset or various lists for each agronomicCropCategory: agronomicCropCategory must be of [EPPO_code | UPOV_code]. Additionally, BLW should provide a dataset or various lists for each directPaymentCrop: directPaymentCrop must be an element of [EPPO_code | UPOV_code]. (i.e. a more stripped down version of directpaymentcropDataset.xml using only ids)

Other miscellaneous info:

  • The agronomicCropCategory are the GRUD crop categories. We should understand where the authority is and initiate the mapping to EPPO codes.

Yes - but perhaps GRUD is not the master! We need to identify the master - and the BLW should refer only to this dataset. For example, the list "Katalog landwirtschaftliche Hauptkulturen" can be found here: https://www.blw.admin.ch/blw/de/home/politik/datenmanagement/geografisches-informationssystem-gis/landwirtschaftliche-kulturflaechen.html. The document's title however is "LNF_Katalog_Nutzungsart" indicating that there might be a different master still, i.e LNF? Or vice versa...

Might be feasible but is still ambitious. The changes suggested will be a major change that needs the ok by AG Agrardaten. Let's first rework the structure of the species by rearranging only the already used elements. This ideally would need the least changes for the Umsysteme.

How do we include Varieties into the modell? Are varieties an element of species? Or are species an element of varieties? This is especially relevant having the question in mind: How to deal with crossbreeds? Or do we not need to modell this as all the information can be mapped using the lists provided?

@hurni your thoughs on that?