search

bmFtZQ / edge-frfox

A Firefox userChrome.css theme that aims to recreate the look and feel of Microsoft Edge.
MIT License
696 stars 38 forks source link

FF 133.0b2 break windows os 's hide-tab-bar.css windows control button #167

Closed rainbowflesh closed 4 weeks ago

rainbowflesh commented 4 weeks ago

The issue: QQ20241031-174618 A quick debug show looks like nav-bar browser-toolbar masked over control button: QQ20241031-174739

rainbowflesh commented 4 weeks ago

A WIP simple fix is change https://github.com/bmFtZQ/edge-frfox/blob/e36eec06b0d1e4ecef1e6052ecd132efbb732e58/chrome/tweaks/hide-tabs-bar.css#L85 to

margin-right: 140px !important;
padding-inline-end: var(--uc-titlebar-drag-space) !important;

QQ20241031-175219

bmFtZQ commented 4 weeks ago

Mozilla added window controls to the #nav-bar in Firefox 133, so I've made some modifications to just display those window controls if they exist, otherwise fallback to positioning the window controls from the #TabsToolbar on older versions of Firefox.

image

This way the window controls cannot be hidden by the #nav-bar element as they are inside of it, and can probably prevent some similar issues in the future.

The issue here is similar to something I fixed earlier this year. Though Mozilla removed the #Titlebar element and applied the same declaration to the #TabsToolbar, so this would have also fixed the issue:

:root[tabsintitlebar] #TabsToolbar {
  will-change: auto !important;
}