search

bmbrands / moodle-theme_elegance

This is the new official elegance repository
http://basbrands.nl
23 stars 12 forks source link

elegance.js does not have a version number #145

Open gjb2048 opened 8 years ago

gjb2048 commented 8 years ago

Hi Bas,

Because elegance.js's filename does not change every time it is updated: https://github.com/bmbrands/moodle-theme_elegance/commits/master/jquery/elegance.js then users will not get a fresh copy of the file when it changes on an update.

Two solutions:

  1. Add a version number as per plugins.php.
  2. Convert all to AMD modules and then can ditch changing the filename per version.

Cheers,

Gareth

bmbrands commented 8 years ago

Thanks for reporting this.

I have tried working with AMD modules but so for I have not been able to write anything that works. The documentation on Moodle.org doesn't really help and there are very few examples of AMD modules in core. So if you know any good sources for learning to write AMD I would certainly be interested.

gjb2048 commented 8 years ago

Hi Bas,

I don't know of any documentation. However I have done all the sort of features that Elegance does, like backstretch.js etc. as AMD modules in my M2.9 themes, so can help if you have questions.

Cheers,

Gareth

Sent from my iPod in deep space...