bmc-toolbox / bmclib

Library to abstract Baseboard Management Controller interaction
Apache License 2.0
189 stars 36 forks source link

Redfish disable Etag match header #353

Closed joelrebel closed 12 months ago

joelrebel commented 12 months ago

What does this PR implement/change/remove?

Work around for (crappy) vendor implementations where the If-Match header does not work - even with '*' as the value, requests are incorrectly denied with an ETag mismatch error.

depends on https://github.com/stmcginnis/gofish/pull/277

Checklist

codecov[bot] commented 12 months ago

Codecov Report

Patch coverage: 33.33% and project coverage change: -0.04% :warning:

Comparison is base (44c2961) 44.56% compared to head (93480d6) 44.53%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #353 +/- ## ========================================== - Coverage 44.56% 44.53% -0.04% ========================================== Files 51 51 Lines 4104 4116 +12 ========================================== + Hits 1829 1833 +4 - Misses 2065 2073 +8 Partials 210 210 ``` | [Files Changed](https://app.codecov.io/gh/bmc-toolbox/bmclib/pull/353?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bmc-toolbox) | Coverage Δ | | |---|---|---| | [internal/redfishwrapper/power.go](https://app.codecov.io/gh/bmc-toolbox/bmclib/pull/353?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bmc-toolbox#diff-aW50ZXJuYWwvcmVkZmlzaHdyYXBwZXIvcG93ZXIuZ28=) | `0.00% <0.00%> (ø)` | | | [providers/redfish/redfish.go](https://app.codecov.io/gh/bmc-toolbox/bmclib/pull/353?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bmc-toolbox#diff-cHJvdmlkZXJzL3JlZGZpc2gvcmVkZmlzaC5nbw==) | `25.53% <25.00%> (-0.03%)` | :arrow_down: | | [internal/redfishwrapper/client.go](https://app.codecov.io/gh/bmc-toolbox/bmclib/pull/353?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bmc-toolbox#diff-aW50ZXJuYWwvcmVkZmlzaHdyYXBwZXIvY2xpZW50Lmdv) | `22.34% <100.00%> (+2.56%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.