search

bnjbvr / cargo-machete

Remove unused Rust dependencies with this one weird trick!
MIT License
808 stars 30 forks source link

Fixes #104: correctly parse id repr for Rust 1.78+ #106

Closed bnjbvr closed 8 months ago

bnjbvr commented 9 months ago

This updates to the new pkgid spec used after Rust 1.77.

Fixes #104. Fixes #114.

utkarshgupta137 commented 8 months ago

Working on macOS (Apple Silicon).

utkarshgupta137 commented 8 months ago

Since this is probably breaking the CI for everyone who has stable testing, may I suggest merging this soon?

bnjbvr commented 8 months ago

Thanks, I'd really like a test by someone on windows though, since paths may be different there (notably slash vs backslash).

epage commented 8 months ago

You shouldn't need any platform-specific testing done. If the output of the old (opaque) id worked for you then extracting it should work here as well because they are both URLs and are platform-independent and you already had to be handling any platform-specific logic for the old id format.

bnjbvr commented 8 months ago

@epage Ah thanks for the information, I hadn't realized this was platform-independent.