search

bnlawrence / cfs

Rebooting cfstore, leaner and meaner
0 stars 1 forks source link

Not handling base paths properly (CFA substitutions etc) #5

Closed bnlawrence closed 1 week ago

bnlawrence commented 2 months ago

E.g. fragment names like this are wrong:

unavailable:cs125_1_mon_z__195208-195208.nc
unavailable:cs125_1_day__198409-198409.nc
unavailable:cs125_1_6hr_pt__200502-200502.nc

Unavailable should be a location. We are not stripping these correctly, or dealing with the substitution variables properly.

bnlawrence commented 2 months ago

Part of the commit referenced above is designed to handle this, but I need unit tests, but I don't know how to set up the cfa file correctly. See the end of the cfa_resources fixture in test_60_cfa_import.py. I need help from the CFA team.

bnlawrence commented 1 month ago

I have a temporary expedient in the unit tests now, using xarray, but we should remove that.

bnlawrence commented 1 month ago

Explicitly, we should remove the xarray hack in the test cfa_resource found in test_60and use the correct CF interface. Given that interface is new, it may be worth considering whether or not it is fit for purpose as is.

bnlawrence commented 1 month ago

This is probably too woolly as a problem description. Suffice to say I think the first issue is to set up some tests, and then pass me the problem of fixing the backend.

bnlawrence commented 1 week ago

We've got rid of base locations!