search

bnoordhuis / v8-cmake

The V8 JavaScript engine, but built with CMake instead of GN - WIP
BSD 3-Clause "New" or "Revised" License
189 stars 54 forks source link

gn_args support? #68

Open JerrySievert opened 1 year ago

JerrySievert commented 1 year ago

given that some embedders need to use different arguments that would normally be passed to gn gen, is there a mechanism for this?

I haven't been able to find any in the existing code other than the predefines in the cmake file. is this currently possible?

bnoordhuis commented 1 year ago

Not supported at the moment but flags can be added on a case-by-case basis (ex. v8_enable_i18n_support)

JerrySievert commented 1 year ago

thanks ben!

the biggest ones i see for plv8 are:

as noted before, v8_enable_i18n_support would be nice, we have a few users who have used it, but it's generally not used.

bnoordhuis commented 1 year ago

v8_use_external_startup_data should not be difficult.

is_component_build=false is basically what we have today, I think? is_component_build=true on the other hand is #60.