search

bob-fornal / talk--presentation-tool

https://bobs-tech-presentations.com
1 stars 2 forks source link

Slide Visibility #1

Closed bob-fornal closed 1 week ago

bob-fornal commented 4 months ago

Need a means of turning a single slide on or off - to be used or not when presenting.

adityaraute commented 1 week ago

A button to toggle a simple pitch black overlay could work for this.

bob-fornal commented 1 week ago

I wish it were that simple. I've got an array of objects, each object representing a slide. I need a key/value pair (say { visible: false }) indicating the slide should be skipped. Additionally, if the key does not exist, we'll treat it as if visible is true. This is just my reminder to wire it up. Thanks for the thought.

adityaraute commented 1 week ago

Oh, I again misinterpreted it. I assumed it meant that you want to switch the presentation screen off (like professors do to handwrite some notes) and then turn it back on.

Your aim seems doable, too. I might have created a Pull Request, but I probably don't have the basic tech stack setup on my machine. Will try with GitPod.

adityaraute commented 1 week ago

Should the unit tests be another issue?

bob-fornal commented 1 week ago

Should the unit tests be another issue?

Unit Tests should be a part of each commit. I've let them slide on this project.

Let me look at the current state of the Unit Tests. There should be tests against the code you merged in, but I will admit that I haven't kept up with the tests as well as I should have. I might have to get the test suite back into a working state before you can add tests for your recent commit. I'll send a note when it can be looked at.

adityaraute commented 1 week ago

Gotcha. Thanks! Will be looking forward to the same.

bob-fornal commented 1 week ago

OK.

I got the Unit Tests into a "non-broken" state. If you try npm run test or ng test now, there shouldn't be any failures. That doesn't mean that we have a high passing rate; I have some new code that doesn't have any testing at the moment. If you want to try to write tests against the code you merged, feel free.

adityaraute commented 1 week ago

Perfect, thanks a lot for the nudge! Is this the same change that you posted on your 100DaysOfCode campaign, too? I believe that circled around testing, too