search

bobbingwide / sb-chart-block

Chart block for Gutenberg
GNU General Public License v3.0
6 stars 0 forks source link

Check need for first two lines of `sb_chart_block_shortcode` #12

Closed bobbingwide closed 2 years ago

bobbingwide commented 3 years ago

Is the logic that sets $attrs necessary. The variable's not used.

function sb_chart_block_shortcode( $atts, $content, $tag ) {
    $attrs = [];
    $attrs[ 'type'] = sb_chart_block_array_get( $atts, 'type', 'Line');
bobbingwide commented 3 years ago

Is the logic that sets $attrs necessary

Apparently not.

bobbingwide commented 2 years ago

This was released in v0.4.1 so closing.