boidushya / better-lyrics

Better Lyrics for Youtube Music - Enhance YouTube Music with beautiful time-synced lyrics, multilingual support, real-time translations and more ✨
https://better-lyrics.boidu.dev
GNU General Public License v3.0
115 stars 12 forks source link

chore(README): Section about permissions #56

Closed boidushya closed 3 months ago

boidushya commented 3 months ago

Description

Section about permissions and explanation for the same

Type of change

Please delete options that are not relevant.

Related Issue (if applicable)

Fixes #55

Checklist

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
better-lyrics ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 17, 2024 2:48pm
tasszz2k commented 3 months ago

Can I continue using this extension without the new required permissions?

Extension Permissions

Permission Reason Data Usage
Read and change all your data on the websites you visit Required to inject lyrics into Youtube Music page & for code editor specific JS & CSS No data stored
Get data from the clipboard Required to import styles and themes from clipboard -
Input data to the clipboard Required to export styles and themes to clipboard -
Download files and read and modify the browser's download history Required to download styles and themes as CSS file Does not read or modify browser's download history
Access browser tabs Required to ensure code editor works on all tabs (changes applied to Youtube Music tab) -
boidushya commented 3 months ago

Yes you can

https://github.com/boidushya/better-lyrics?tab=readme-ov-file#i-dont-like-the-new-update-can-i-revert-to-the-old-version

https://github.com/boidushya/better-lyrics?tab=readme-ov-file#chrome

https://github.com/boidushya/better-lyrics/releases/tag/v1.6.3

Can I continue using this extension without the new required permissions?

Extension Permissions

Permission Reason Data Usage Read and change all your data on the websites you visit Required to inject lyrics into Youtube Music page & for code editor specific JS & CSS No data stored Get data from the clipboard Required to import styles and themes from clipboard - Input data to the clipboard Required to export styles and themes to clipboard - Download files and read and modify the browser's download history Required to download styles and themes as CSS file Does not read or modify browser's download history Access browser tabs Required to ensure code editor works on all tabs (changes applied to Youtube Music tab) -

tasszz2k commented 3 months ago

Could you set these permissions to optional instead of required?

Anyone who wants to use these features can enable the corresponding permissions instead of accepting all permissions like this update.

boidushya commented 3 months ago

In an upcoming hotfix v1.7.2 I'll remove the clipboardRead and clipboardWrite permissions. I'll also try to move the downloads permission to be optional. I'm afraid the tabs one needs to be persistent though

tasszz2k commented 3 months ago

because these permissions are quite critical, I am afraid that people will be concerned about the security aspect when using it.

For instance, "Read and change all your data on the websites you visit ", why isn't it the YouTube music website only?

boidushya commented 3 months ago

https://github.com/boidushya/better-lyrics?tab=readme-ov-file#extension-permissions Explanation here ^

tasszz2k commented 3 months ago

sorry, but people concerned about security cannot ensure these permissions won't be used for other purposes in the future.

why don't you set them to optional? Users still have a choice to enable them to use these features.

boidushya commented 3 months ago

Check #57

If you have any comments, please move to a separate issue or discord