bokmann / font-awesome-rails

the font-awesome font bundled as an asset for the rails asset pipeline
http://fortawesome.github.com/Font-Awesome/
MIT License
1.86k stars 244 forks source link

file-alt Missing Icon #201

Closed derrickmar closed 5 years ago

derrickmar commented 5 years ago

I have tried all the steps in (https://github.com/bokmann/font-awesome-rails/blob/master/.github/CONTRIBUTING.md).

<%= fa_icon "file-alt" %> is missing. <%= fa_icon "file" %> works however. Example: Notice how in the User Manual the file-alt icon is not being rendered

screenshot 2018-08-11 11 00 15

bundle list | grep 'rails|awesome|sass|less'

  * coffee-rails (4.2.2)
  * dotenv-rails (2.5.0)
  * font-awesome-rails (4.7.0.4)
  * rails (5.2.0)
  * rails-dom-testing (2.0.3)
  * rails-html-sanitizer (1.0.4)
  * sass (3.5.6)
  * sass-listen (4.0.0)
  * sass-rails (5.0.7)
  * sprockets-rails (3.2.1)
rmm5t commented 5 years ago

I have tried all the steps in (https://github.com/bokmann/font-awesome-rails/blob/master/.github/CONTRIBUTING.md).

Thus is actually a clean issue report, but you missed step 2.

2) Make sure the icon still exists in FontAwesome (sometimes icons are renamed between versions).

file-alt was renamed to file-o.

https://fontawesome.com/v4.7.0/icons/

derrickmar commented 5 years ago

@rmm5t thanks for the help. I thought we were on version 5, but just realized it's on 4.7. Is there any plans to upgrade? I was looking at these fonts

https://fontawesome.com/icons?d=gallery&q=file-alt

rmm5t commented 5 years ago

Licensing changed when they switched to version 5. There’s an open issue to upgrade, but there hasn’t been any progress on that front yet, because we’re not sure how (if at all) to handle the paid versions of the icons.

I also haven’t been on a project that needs the upgrade yet, so I haven’t felt the pain or had the time to understand the changes to make the necessary changes for this gem yet either.

derrickmar commented 5 years ago

Gotcha. Appreciate it @rmm5t