search

bokmann / font-awesome-rails

the font-awesome font bundled as an asset for the rails asset pipeline
http://fortawesome.github.com/Font-Awesome/
MIT License
1.86k stars 244 forks source link

Remove transitive dependency on sass gem #203

Closed adjam closed 5 years ago

adjam commented 5 years ago

As of v4.7.0.5, this gem has a dependency on sass-rails which in turn depends on sass; the latter gem has been deprecated (http://sass.logdown.com/posts/7828841).

Probably the easiest change is to swap out the dependency in the gemspec for sassc-rails.

rmm5t commented 5 years ago

this gem has a dependency on sass-rails

Clarifying. Not exactly. It has a "development" dependency on sass-rails. This has no bearing on anyone's usage of the gem.

[sass] gem has been deprecated (http://sass.logdown.com/posts/7828841).

Good to know. Thanks.

Probably the easiest change is to swap out the dependency in the gemspec for sassc-rails.

Please do investigate. A PR ensuring the test suite still runs green using sassc-rails would be much appreciated.