boltdesignsystem / bolt

The Bolt Design System provides robust Twig and Web Component-powered UI components, reusable visual styles, and powerful tooling to help developers, designers, and content authors build, maintain, and scale best of class digital experiences.
https://boltdesignsystem.com
MIT License
291 stars 46 forks source link

DS 886: Teaser Updates #2575

Closed MarcinMr closed 2 years ago

MarcinMr commented 2 years ago

Jira

https://pegadigitalit.atlassian.net/browse/DS-886

Summary

The Teaser was updated with two props that can more completely replace the Card Component.

Details

1. A spacing prop with the following options was added

2. A border_radius prop with the following options was added

3. A test page was created with all new props options /pattern-lab/?p=tests-teaser-spacing-and-border-radius

How to test

Pull the branch. Check the test page and confirm that the new props work as expected and the component can more completely replace old Card.

Release notes

The Teaser component has two new props (spacing, border_radius) that can be applied to the card variant teaser .

Visual changes

The spacing and the corner roundness can be adjusted in the card variant teaser component.

MarcinMr commented 2 years ago

@MarcinMr I'd like to see a demo page as well, something public facing since the test pages are hidden.

True:) I'll add a demo example

MarcinMr commented 2 years ago

@cjwhitedev updated the docs, it's ready for review again

colbytcook commented 2 years ago

@MarcinMr I think we should adjust the large prop value border radius value to 0.37em to better align with the outer radius. Refer to the adjustments I made in the browser to see the change. Let me know if you have any other questions regarding this.

radius-adjustment
MarcinMr commented 2 years ago

@colbytcook I updated the signifier border-radius to 0.37em

colbytcook commented 2 years ago

@MarcinMr approved, feel free to merge

MarcinMr commented 2 years ago

@colbytcook Merged