Change to use umami-api, remove node-fetch

jakobbouchard commented 2 years ago

Hey! Really like your work! Since I made my own API too, I wanted to know if you wanted to use it instead. It has typings, making it easier to use (in my opinion), and I already added a lot more API endpoints than those listed in the docs :)

jakobbouchard commented 2 years ago

I now have all the available endpoints programmed in.

boly38 commented 2 years ago

Hi @jakobbouchard

welcome and thanks for your contribution. 👏

My side I have just a small experience with typescript, anyway your clone seems more advanced than mine, so ok to switch.

As it's usable from JavaScript this is ok for me.

Could you do this little changes please:

if possible: squash your 3 commits in a single one
update readme : the umami client reference (in umami section)
create a related issue, and reference this issue from your commit content "Fix #xx blah blah" : because the commit text will be reused by gren (generated) release notes (a "v2.0" :) ).

To fix audit, I will just update deps right now, you will need to rebase your squashed commit, and then I ll merge it (make it node fetch to dissapear)

jakobbouchard commented 2 years ago

Cool! I'll do this very soon, I've just been quite busy since I just started university :)

jakobbouchard commented 2 years ago

Hey @boly38! I just made the changes you requested :) I also updated to the latest version of my API client. If there's anything else, let me know!

boly38 commented 2 years ago

merged with #30 ; thanks 🙏

boly38 / action-umami-report

Change to use umami-api, remove node-fetch #25