search

bookieio / Bookie

Python based delicious.com replacement
GNU Affero General Public License v3.0
633 stars 138 forks source link

Added test for duplicate tags. Added animation. #361

Closed suryatech closed 10 years ago

suryatech commented 10 years ago

Modified tests to prevent race situations. Used wait construct instead.

sambuddhabasu commented 10 years ago

Tested the pull request. The JS tests run fine. make lint is clean. @mitechie Do let me know if I am missing any other step for testing the code.

suryatech commented 10 years ago

@sammyshj : Thanks for your time. What do you think about the animation. Is 0.1 s fine or should it be increased/decreased?

mitechie commented 10 years ago

Thanks for this, since the original issue in #198 was that Bookie removed the dupe and it wasn't clear why, I slowed it down to .4s so that it's obvious that there's something going on and the user hopefully puts it all together now.

Thanks for the branch, the tests, and your patience as it all got worked out.

suryatech commented 10 years ago

Great! I thought that a larger duration might make it 'appear' slow. Anyways, thanks for the change.