bookingactivities / booking-activities

Wordpress plugin booking system
GNU General Public License v3.0
27 stars 8 forks source link

Succesfull booking shows pending in invoice #186

Closed rayedgar closed 1 year ago

rayedgar commented 1 year ago

After successful payment the WC invoice sent to customer show status "pending" in the WC completed order email. The invoice in thankyou page shows has status "booked" The booking in BA itself seems to be fine and is status "booked".

In BA settings; default booking state is set to : Booked and default payment is set to Paid.

Seems to have happened in update 1.1.5.8 checked with older stage environment 1.15.7 and WC 7.3.0 which seems to not show this problem.. current setup BA 1.15.9 / WC 7.4.1. i have this problem with.

I downgraded to 1.15.7 and that seems to give no problem with problem described above, With update1.1.5.8 this started to happen. And can reproduce. Would it be safe to downgrade 1.15.9 to 1.15.7 on live site?

Screenshot 2023-03-02 at 11 41 12 Screenshot 2023-03-02 at 11 37 32
yoancutillas commented 1 year ago

Thank you for reporting, I could reproduce and fix the issue. The fix is queued for the next version. I don't know if it is safe to rollback to 1.15.7, I would recommand applying the fix of the commit mentionned above instead.

rayedgar commented 1 year ago

Thank you for the fix. Our live site is running 1.15.9 your fix was for .8 to .10 could i still copy the code? or is it safe to copy all code from latest version on Github?

yoancutillas commented 1 year ago

Yes, it's just that the code for these functions has not changed since 1.15.8, that's why the version of the functions bumps from 1.15.8 to 1.15.10.