booksaw / BetterTeams

Create teams to fight to be the best (Minecraft Plugin)
https://www.spigotmc.org/resources/better-teams.17129/
MIT License
63 stars 43 forks source link

Protocol [BUG] #618

Open StarGamerShalom opened 2 weeks ago

StarGamerShalom commented 2 weeks ago

What is the bug?

Protocol Error

Expected Behaviour

Not to have this happen and for fallback server to work when server restarts or goes down. Yes I know this is not support for the fallback plugin so not expecting help with it. Just need error to be resolved so that hopefully fallback will work and not just kick you from the servers and give a protocol error. The only plugin in this server with teams is Better Teams.

How to Reproduce

  1. Proxy uses Velocity
  2. Install on Lobby
  3. Have Fallbackserver setup on Proxy maybe Geyser /Floodgate setup on all servers too. Though myself and friend who is helping both play Java and get this.
  4. Do a restart on lobby server while you are in game.

Error message

---- Minecraft Network Protocol Error Report ---- // Abort, Retry, Ignore?

Time: 2024-06-18 13:26:21 Description: Packet handling error

java.lang.IllegalStateException: Player is either on another team or not on any team. Cannot remove from team 'Bandits'. at eyg.b(SourceFile:308) at fzg.a(SourceFile:2050) at afh.a(SourceFile:132) at afh.a(SourceFile:18) at zj.a(SourceFile:27) at bph.d(SourceFile:162) at bpl.d(SourceFile:23) at bph.B(SourceFile:136) at bph.bB(SourceFile:121) at fgo.c(SourceFile:1240) at fgo.f(SourceFile:882) at net.minecraft.client.main.Main.main(SourceFile:256)

A detailed walkthrough of the error, its code path and all known details is as follows:

-- Head -- Thread: Render thread Stacktrace: at eyg.b(SourceFile:308)

-- Incoming Packet -- Details: Type: clientbound/minecraft:set_player_team Is Terminal: false Is Skippable: false Stacktrace: at zj.a(SourceFile:56) at fzc.a(SourceFile:136) at fzc.a(SourceFile:113) at zj.a(SourceFile:32) at bph.d(SourceFile:162) at bpl.d(SourceFile:23) at bph.B(SourceFile:136) at bph.bB(SourceFile:121) at fgo.c(SourceFile:1240) at fgo.f(SourceFile:882) at net.minecraft.client.main.Main.main(SourceFile:256)

-- Connection -- Details: Protocol: play Flow: CLIENTBOUND Server type: OTHER Server brand: Paper (Velocity)

-- System Details -- Details: Minecraft Version: 1.21 Minecraft Version ID: 1.21 Operating System: Windows 11 (amd64) version 10.0 Java Version: 21.0.3, Microsoft Java VM Version: OpenJDK 64-Bit Server VM (mixed mode), Microsoft Memory: 752459016 bytes (717 MiB) / 1241513984 bytes (1184 MiB) up to 2147483648 bytes (2048 MiB) CPUs: 2 Processor Vendor: AuthenticAMD Processor Name: AMD Athlon Silver 3050U with Radeon Graphics
Identifier: AuthenticAMD Family 23 Model 24 Stepping 1 Microarchitecture: Zen / Zen+ Frequency (GHz): 2.30 Number of physical packages: 1 Number of physical CPUs: 2 Number of logical CPUs: 2 Graphics card #0 name: AMD Radeon(TM) Graphics Graphics card #0 vendor: Advanced Micro Devices, Inc. Graphics card #0 VRAM (MiB): 2048.00 Graphics card #0 deviceId: VideoController1 Graphics card #0 versionInfo: 31.0.12044.3 Memory slot #0 capacity (MiB): 8192.00 Memory slot #0 clockSpeed (GHz): 2.67 Memory slot #0 type: DDR4 Virtual memory max (MiB): 19411.68 Virtual memory used (MiB): 14121.71 Swap memory total (MiB): 13387.79 Swap memory used (MiB): 1683.55 Space in storage for jna.tmpdir (MiB): available: 34735.25, total: 121132.00 Space in storage for org.lwjgl.system.SharedLibraryExtractPath (MiB): available: 34735.25, total: 121132.00 Space in storage for io.netty.native.workdir (MiB): available: 34735.25, total: 121132.00 Space in storage for java.io.tmpdir (MiB): available: 34735.25, total: 121132.00 Space in storage for workdir (MiB): available: 34735.25, total: 121132.00 JVM Flags: 9 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xss1M -Xmx2G -XX:+UnlockExperimentalVMOptions -XX:+UseG1GC -XX:G1NewSizePercent=20 -XX:G1ReservePercent=20 -XX:MaxGCPauseMillis=50 -XX:G1HeapRegionSize=32M

Output of /teama version

[18.06 17:34:39] [Server] [INFO] Minecraft Version: git-Paper-497 (MC: 1.20.4) [18.06 17:34:39] [Server] [INFO] Language Selected: messages [18.06 17:34:39] [Server] [INFO] Online mode: false [18.06 17:34:39] [Server] [INFO] Player count: 1 [18.06 17:34:39] [Server] [INFO] Current plugin version: 4.9.4

Additional Information

Bandits is my Team name and not sure why it is trying to remove me from it. Only thing I can think of is it is part of how the plugin closes/shuts down when server does a restart and something is off. Other than that I have not tried to remove team Bandits on purpose.

StarGamerShalom commented 2 weeks ago

Tried disabling the Better Teams plugin and that seemed to fix the issue no more protocol errors and fallback is working fine.

I also got a slightly different protocol error I will send here after switching to fallbacks last stable build and not their beta. Not sure it will be helpful but thought would send anyway since this one said something about failure to communicate.

---- Minecraft Network Protocol Error Report ---- // What we've got here is failure to communicate

Time: 2024-06-18 14:17:36 Description: Packet handling error

java.lang.IllegalStateException: Player is either on another team or not on any team. Cannot remove from team 'Bandits'. at eyg.b(SourceFile:308) at fzg.a(SourceFile:2050) at afh.a(SourceFile:132) at afh.a(SourceFile:18) at zj.a(SourceFile:27) at bph.d(SourceFile:162) at bpl.d(SourceFile:23) at bph.B(SourceFile:136) at bph.bB(SourceFile:121) at fgo.c(SourceFile:1240) at fgo.f(SourceFile:882) at net.minecraft.client.main.Main.main(SourceFile:256)

A detailed walkthrough of the error, its code path and all known details is as follows:

-- Head -- Thread: Render thread Stacktrace: at eyg.b(SourceFile:308)

-- Incoming Packet -- Details: Type: clientbound/minecraft:set_player_team Is Terminal: false Is Skippable: false Stacktrace: at zj.a(SourceFile:56) at fzc.a(SourceFile:136) at fzc.a(SourceFile:113) at zj.a(SourceFile:32) at bph.d(SourceFile:162) at bpl.d(SourceFile:23) at bph.B(SourceFile:136) at bph.bB(SourceFile:121) at fgo.c(SourceFile:1240) at fgo.f(SourceFile:882) at net.minecraft.client.main.Main.main(SourceFile:256)

-- Connection -- Details: Protocol: play Flow: CLIENTBOUND Server type: OTHER Server brand: Paper (Velocity)

-- System Details -- Details: Minecraft Version: 1.21 Minecraft Version ID: 1.21 Operating System: Windows 11 (amd64) version 10.0 Java Version: 21.0.3, Microsoft Java VM Version: OpenJDK 64-Bit Server VM (mixed mode), Microsoft Memory: 611297360 bytes (582 MiB) / 1241513984 bytes (1184 MiB) up to 2147483648 bytes (2048 MiB) CPUs: 2 Processor Vendor: AuthenticAMD Processor Name: AMD Athlon Silver 3050U with Radeon Graphics
Identifier: AuthenticAMD Family 23 Model 24 Stepping 1 Microarchitecture: Zen / Zen+ Frequency (GHz): 2.30 Number of physical packages: 1 Number of physical CPUs: 2 Number of logical CPUs: 2 Graphics card #0 name: AMD Radeon(TM) Graphics Graphics card #0 vendor: Advanced Micro Devices, Inc. Graphics card #0 VRAM (MiB): 2048.00 Graphics card #0 deviceId: VideoController1 Graphics card #0 versionInfo: 31.0.12044.3 Memory slot #0 capacity (MiB): 8192.00 Memory slot #0 clockSpeed (GHz): 2.67 Memory slot #0 type: DDR4 Virtual memory max (MiB): 19411.68 Virtual memory used (MiB): 13893.95 Swap memory total (MiB): 13387.79 Swap memory used (MiB): 1524.25 Space in storage for jna.tmpdir (MiB): available: 34842.25, total: 121132.00 Space in storage for org.lwjgl.system.SharedLibraryExtractPath (MiB): available: 34842.25, total: 121132.00 Space in storage for io.netty.native.workdir (MiB): available: 34842.25, total: 121132.00 Space in storage for java.io.tmpdir (MiB): available: 34842.25, total: 121132.00 Space in storage for workdir (MiB): available: 34842.25, total: 121132.00 JVM Flags: 9 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xss1M -Xmx2G -XX:+UnlockExperimentalVMOptions -XX:+UseG1GC -XX:G1NewSizePercent=20 -XX:G1ReservePercent=20 -XX:MaxGCPauseMillis=50 -XX:G1HeapRegionSize=32M

StarGamerShalom commented 3 days ago

? Any updates on this?

StarGamerShalom commented 3 days ago

I do not want to have to disable this plugin on the server but it is still causing players to get disconnected with this protocol error instead of falling them back to another server.

booksaw commented 2 days ago

From other reports, it seems to be related in some way to ViaVersion not working as expected. Could you share what version of viaversion you are using along with the range of versions you let join your minecraft server. You may be able to find a pattern, as at least on a different server the issue only occurs for 1.20.6-1.21 clients attempting to join 1.20.x servers so it may be something similar.

StarGamerShalom commented 2 days ago

Using Viaversion 5.0.1 also have viabackward 5.0.1 I do not have any versions restricted and allow java and bedrock players in. Backend servers are 1.20.4 but players can enter up to 1.21. I am actually in when getting these messages and errors as 1.21.

AnCry1596 commented 2 days ago

I have this problem althought my server doesn't have ViaVersion and ViaBackward

---- Minecraft Network Protocol Error Report ---- // +'${`%&NO CARRIER

Time: 2024-07-01 13:44:52 Description: Packet handling error

java.lang.IllegalStateException: Player is either on another team or not on any team. Cannot remove from team 'Ilumatic2'. at eyg.b(SourceFile:308) at fzg.a(SourceFile:2050) at afh.a(SourceFile:132) at afh.a(SourceFile:18) at zj.a(SourceFile:27) at bph.d(SourceFile:162) at bpl.d(SourceFile:23) at bph.B(SourceFile:136) at bph.bB(SourceFile:121) at fgo.c(SourceFile:1240) at fgo.f(SourceFile:882) at net.minecraft.client.main.Main.main(SourceFile:256)

A detailed walkthrough of the error, its code path and all known details is as follows:

-- Head -- Thread: Render thread Stacktrace: at eyg.b(SourceFile:308)

-- Incoming Packet -- Details: Type: clientbound/minecraft:set_player_team Is Terminal: false Is Skippable: false Stacktrace: at zj.a(SourceFile:56) at fzc.a(SourceFile:136) at fzc.a(SourceFile:113) at zj.a(SourceFile:32) at bph.d(SourceFile:162) at bpl.d(SourceFile:23) at bph.B(SourceFile:136) at bph.bB(SourceFile:121) at fgo.c(SourceFile:1240) at fgo.f(SourceFile:882) at net.minecraft.client.main.Main.main(SourceFile:256)

-- Connection -- Details: Protocol: play Flow: CLIENTBOUND Server type: OTHER Server brand: Paper

-- System Details -- Details: Minecraft Version: 1.21 Minecraft Version ID: 1.21 Operating System: Windows 10 (amd64) version 10.0 Java Version: 21.0.3, Microsoft Java VM Version: OpenJDK 64-Bit Server VM (mixed mode), Microsoft Memory: 159252648 bytes (151 MiB) / 973078528 bytes (928 MiB) up to 2147483648 bytes (2048 MiB) CPUs: 8 Processor Vendor: GenuineIntel Processor Name: Intel(R) Core(TM) i3-10100 CPU @ 3.60GHz Identifier: Intel64 Family 6 Model 165 Stepping 3 Microarchitecture: Comet Lake Frequency (GHz): 3.60 Number of physical packages: 1 Number of physical CPUs: 4 Number of logical CPUs: 8 Graphics card #0 name: Intel(R) UHD Graphics 630 Graphics card #0 vendor: Intel Corporation Graphics card #0 VRAM (MiB): 1024.00 Graphics card #0 deviceId: VideoController1 Graphics card #0 versionInfo: 31.0.101.2127 Memory slot #0 capacity (MiB): 8192.00 Memory slot #0 clockSpeed (GHz): 2.67 Memory slot #0 type: DDR4 Memory slot #1 capacity (MiB): 16384.00 Memory slot #1 clockSpeed (GHz): 2.67 Memory slot #1 type: DDR4 Virtual memory max (MiB): 25951.84 Virtual memory used (MiB): 10350.47 Swap memory total (MiB): 1536.00 Swap memory used (MiB): 411.14 Space in storage for jna.tmpdir (MiB): available: 388548.09, total: 953228.25 Space in storage for org.lwjgl.system.SharedLibraryExtractPath (MiB): available: 388548.09, total: 953228.25 Space in storage for io.netty.native.workdir (MiB): available: 388548.09, total: 953228.25 Space in storage for java.io.tmpdir (MiB): available: 388548.09, total: 953228.25 Space in storage for workdir (MiB): available: 388548.09, total: 953228.25 JVM Flags: 9 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xss1M -Xmx2G -XX:+UnlockExperimentalVMOptions -XX:+UseG1GC -XX:G1NewSizePercent=20 -XX:G1ReservePercent=20 -XX:MaxGCPauseMillis=50 -XX:G1HeapRegionSize=32M

booksaw commented 2 days ago

@AnCry1596 could you share the full output of /teama debug?

Also for everyone else, a current solution to use most of betterteams would be to set useTeams to false in config.yml, it will disable the feature of displaying the team name in the TAB menu, but apart from that it will work as expected.

AnCry1596 commented 1 day ago

image @booksaw here is mine /teama debug

AnCry1596 commented 1 day ago

I tested with useTeams to false in my server, it become very very lagging and sometime is unplayable

StarGamerShalom commented 1 day ago

Interesting I have not changed my useTeams to false yet been working on other things. But my Server Version is 1.20.4. I do have Viaversion Viabackward and Geyser. Better Teams 4.9.4. Even though I have not turned it off yet I find the lag part interesting because with some updates I have found the server more laggy with intermittent very short freeze points. I was trying to figure out the cause. It may not be related but when get a change I will disable or remove teams temp and see what happens.

my teama info image